-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to stream command output as a response (fixes conflict #443) #549
base: master
Are you sure you want to change the base?
Conversation
would it be possible to get this merged? we've got a long running command, and only see the output after everything finished. streaming the output would be really great. |
Much needed. Please merge. |
Any news about this PR? The feature would be quite useful. |
For the s3import script seems useful to print the output as it happens, as version 2.8.0 of webhook does not have this functionality we are applying the PR 549 (adnanh/webhook#549) and building the binary for alpine.
Any news about this PR? |
I'll try to test this out next week, and hopefully get it merged if I don't run into any issues :) |
Hmm, in order to get the streaming to work, I had to set these headers in the response as well:
Without those headers I observed command output not being streamed, but rather buffered & spit out after the connection is closed. Do you think this header override is acceptable? Another question, should we also stream the output to the logs in parallel, maybe even introduce a separate setting "include-command-output-in-the-logs" (or something less verbose)? :) |
I think it's reasonable to override the headers if streaming requires it. Additionally, an include-command-output-in-the-logs option would be useful, since not everyone might want to enable this feature |
@adnanh any updates on this PR? Need this feature urgently, please let know if you are merging it? |
Just fix conflict pr #443, thanks @milolav