Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick draft for adding some basic Prometheus metrics at
/metrics
if the-metrics
flag is passed.If you're open to adding metrics in general I would add some more metrics for the remaining error conditions and hook execution time.
In case you don't like the addition of all those dependencies I could also switch the implementation to use https://github.com/VictoriaMetrics/metrics which doesn't have as many useful features but is also a lot smaller.
Current custom metrics example:
Solves #527