-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple Vision Pro washed out / lighter colors #5444
Comments
This is annoying. In theory all we'd have to do is set
Not to mention, that if Apple changes it to be in line with the other implementations (or vice versa), any workarounds already in place will instead cause incorrect colours. Not sure what the best approach going forward is, but since WebXR is still behind a flag on AVP, I think an opt-in property or something would be safest, until it's clear if this behaviour is intended or not. |
Seems might be due to Vision Pro displays being p3. Might need some spec work. Found relevant convo. |
Short term hack might be necessary:
|
@dmarcos any updates on a fix for this? I had tried manually adding a gamma correction in a shader and it helped a little but wasn't great :s It's making our splats look sad in https://github.com/mkkellogg/GaussianSplats3D @mkkellogg FYI |
@dlazares This has to be fixed at the Safari / WebXR spec level not A-Frame |
thanks @dmarcos, tracking is here https://bugs.webkit.org/show_bug.cgi?id=270465 and also a short-term hack described in it as well. |
Thanks. I've been told Apple team is aware of it and working on it. I think timeline depends whether it requires modifying the WebXR spec or not. |
Testing again, this seems fully resolved on the latest visionOS 2.0 Beta / Safari 18 Beta. |
Nice! Thanks so much for testing |
Might be gamma issues. Can test with any of the A-Frame examples and compare with Meta Browser.
The text was updated successfully, but these errors were encountered: