-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(explorer): Add configs and formatting to discrete comparison columns #29553
feat(explorer): Add configs and formatting to discrete comparison columns #29553
Conversation
/testenv up FLAG_CHART_PLUGINS_EXPERIMENTAL=True |
@yousoph Ephemeral environment spinning up at http://35.87.123.148:8080. Credentials are |
6a76dc9
to
2daf04e
Compare
/testenv up FLAG_CHART_PLUGINS_EXPERIMENTAL=True |
@yousoph Ephemeral environment spinning up at http://34.221.74.42:8080. Credentials are |
if (timeComparisonStatus) { | ||
/** | ||
* Replace numeric columns with sets of comparison columns. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Allow the user to customize the comparison columns individually instead of being dictated by the parent metrics' configurations and formatting.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
B:
old-column-config.mov
A:
new-column-config.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION