Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update config for node_modules #830

Open
ojbravo opened this issue Aug 2, 2024 · 0 comments
Open

[chore] Update config for node_modules #830

ojbravo opened this issue Aug 2, 2024 · 0 comments

Comments

@ojbravo
Copy link
Collaborator

ojbravo commented Aug 2, 2024

There are a few config setting we can remove now that we're on node_modules.

ojbravo added a commit that referenced this issue Aug 2, 2024
Updated configuration to resolve eslint conflicts...

- Switched to node-modules in .yarnrc.yml. This resolved a prettier +
eslint confict.
- Added e2e folder to .eslintrc.json so tests could be linted.
- Moved playwright from devdependancies to dependencies in package.json
because the errors said so.
- Added tailwind.config.js, cypress.config.js, and playwright.config.ts
to the .eslintignore
- Updated a few files in /pages to pass ESLint rules
- Added two Playwright test files
- Updated Github Actions React/Cypress tests to use Node v18

All e2e tests are passing.

To Do List:
- #830
- #831

---------

Co-authored-by: Bill Himmelsbach <[email protected]>
billhimmelsbach added a commit that referenced this issue Aug 8, 2024
Updated configuration to resolve eslint conflicts...

- Switched to node-modules in .yarnrc.yml. This resolved a prettier +
eslint confict.
- Added e2e folder to .eslintrc.json so tests could be linted.
- Moved playwright from devdependancies to dependencies in package.json
because the errors said so.
- Added tailwind.config.js, cypress.config.js, and playwright.config.ts
to the .eslintignore
- Updated a few files in /pages to pass ESLint rules
- Added two Playwright test files
- Updated Github Actions React/Cypress tests to use Node v18

All e2e tests are passing.

To Do List:
- #830
- #831

---------

Co-authored-by: Bill Himmelsbach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant