Save only the relative path of the filename in storeFileWithOptions

[amitaibu]

Right now, on StaticDirStorage we save the filename with the full file path https://example.com/static/image/foo.jpg

ihp/IHP/FileStorage/ControllerFunctions.hs

Lines 106 to 115 in 4526f58

	StaticDirStorage -> do
	let destPath :: Text = "static/" <> objectPath
	Directory.createDirectoryIfMissing True (cs $ "static/" <> directory)
	fileInfo
	|> (.fileContent)
	|> LBS.writeFile (cs destPath)
	let frameworkConfig = ?context.frameworkConfig
	pure $ frameworkConfig.baseUrl <> "/" <> objectPath

I think it's better to save it as /image/foo.jpg; it takes less space and is more flexible if the base path is changed.

[mpscholten]

Agree. I think it was done to be consistent with the S3 storage method (as that also generates a full absolute url). But I see the point in changing that, so in case it's not breaking anything let's do this 👍