🐞 fix: implement normalization support for class instances with getter functions #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When returning class instances which use getter functions, normalization does not work in stripping those fields. Typeboxes
Cleandoes not remove getter instances on objects in certain scenarios. This came to my mind because the prisma ORM uses this when defining extensions resulting in the inability to return database query outputs directly. My PR adjusts the clean call to traverse the prototype tree of a passed object, gathering all values located behind a get call and merging them with the original value. It does so in a performance sensitive manner, I check if the operations are required before blindly applying them.Would be great if you could take a look @SaltyAom and I'd be happy to receive feedback/make any necessary changes. Thanks for your work!