-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Integration tests (example split continuation) #5492
base: master
Are you sure you want to change the base?
New Integration tests (example split continuation) #5492
Conversation
With the changes on 41cecb0, I was able to remove dependencies and monitor the execution details for the examples repo (Note that I tested it between my forks). In the logs the URL of the executed pipeline is included so it is much easier to follow. Failed caseSuccess caseOther casesI added a timeout to 10m (harcoded) in case that there are any infra issues but I was not able to simulate that error. |
Some notes that might require us to fine-tune this decision (cc: @expressjs/express-tc and Captains). As it stands, the idea is to remove the examples from the Express core and keep them as a separate repository at https://github.com/expressjs/examples so they can evolve independently (ES6, latest versions, etc.). Currently, the examples are used as part of the testing process, so if we separate them, we'll lose the capability to run them locally. Additionally, if we look at the fork (https://github.com/UlisesGascon/express-examples/blob/main/.github/workflows/ci.yml), the idea is to use the newer versions of Node.js, which are more aligned with Express@5 (see: #5595). So, what do you think?
|
Main Changes
This PR introduces a new pipeline
.github/workflows/integration-tests.yml
..github/workflows/ci.yml
inexpressjs/examples
.UlisesGascon/express-examples
Important
While this PRs triggers the process, does not wait until the.github/workflows/ci.yml
is completed (fail or success) and also does not provide feedback, for example the action executed URL or similar. I think that this PR is a good step in the right direction but not yet enough in terms of DXHere you can find some screenshots on how it works
From Express fork:
![Screenshot 2024-02-18 at 18 26 54](https://private-user-images.githubusercontent.com/5110813/305734251-dd3dd336-caa1-4eb9-8df9-1500c736fce7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUwNzM4MDMsIm5iZiI6MTcyNTA3MzUwMywicGF0aCI6Ii81MTEwODEzLzMwNTczNDI1MS1kZDNkZDMzNi1jYWExLTRlYjktOGRmOS0xNTAwYzczNmZjZTcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgzMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MzFUMDMwNTAzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YzY3ZTM5NWVkYjhlMzY5YTc1ZmNiMmY2N2RkOTMxZjY5ZDk0YjVmZjg1OTEyYjg2ZDQyMTJiNjM3M2ZiZjM2MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.hfHRJt2u8OOr5bRLq6xR7bi2KNqrqHpTOTG0Xejb63U)
From Examples fork:
Context
This PR is supported by UlisesGascon/express-examples#7 and UlisesGascon/express-examples#8
Notes
.github/workflows/integration-tests.yml
is the only thing in scope in this PR.github/workflows/integration-tests.yml
will fail until the repoulisesgascon/express-examples
is migrated toexpressjs/examples
Changelog