-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blog): authors page #10216
feat(blog): authors page #10216
Conversation
⚡️ Lighthouse report for the deploy preview of this PR
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +628 kB (+5.78%) 🔍 Total Size: 11.5 MB
ℹ️ View Unchanged
|
Not sure about this poc refactor
The filter of the page author is now done in getPageAuthor instead of normalizeAuthor So now we normalize all authors, and for the pageAuthor, we get only the authors with a generatePage === true Is it better like this or the way before ? 🤷 |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This introduced a breaking change for me. I was using:
But it does not longer exists 😞 |
I think you need to replace it with the following @csantos-nydig : |
It's not public API so it's not to be considered as a breaking change When swizzling unsafe components, you should understand that with the disclaimers in docs and CLI |
Motivation
#10196
Todo
Test Plan
Dogfood, unit tests, E2E
- enable argos at the end
Test links
Docs:
Related issues/PRs
Fix #10196