always proxy to @react-native-community/cli #45464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D59805357 |
tido64
approved these changes
Jul 17, 2024
Summary: Pull Request resolved: facebook#45464 Previous work would cause versions >= react-native 0.76 to exit if called through `npx react-native <cmd>`. This was intended to be full deprecated and removed. The intention was to shift users to calling react-native-community/cli directly. This change allows commands to be proxied to react-native-community/cli but with no guarantees of success. It's up to each framework / project to explicitly create that dependency. This also provides warnings, which won't go away, suggesting the supported method of calling the community CLI directly. The outcome is that we're not going to break existing workflows. closes: facebook#45461 Changelog: [General][Fixed] allow proxying commands from react-native to react-native-community/cli with explicit warning Differential Revision: D59805357
|
This pull request was exported from Phabricator. Differential Revision: D59805357 |
tido64
reviewed
Jul 18, 2024
| return; | ||
| } | ||
|
|
||
| console.warn(` | ||
| ${chalk.yellow('⚠')}️ The \`init\` command is deprecated. | ||
| ${chalk.yellow('🚨')}️ The \`init\` command is deprecated. |
There was a problem hiding this comment.
Nit: I don't think you can color 🚨:
Suggested change
| ${chalk.yellow('🚨')}️ The \`init\` command is deprecated. | |
| 🚨 The \`init\` command is deprecated. |
Or you can, but it won't actually do anything.
There was a problem hiding this comment.
Sorry I missed this. You're right it's a total noop.
|
This pull request was successfully merged by @blakef in 9aed45a When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 9aed45a. |
cipolleschi
pushed a commit
that referenced
this pull request
Jul 22, 2024
Summary: Pull Request resolved: #45464 Previous work would cause versions >= react-native 0.76 to exit if called through `npx react-native <cmd>`. This was intended to be full deprecated and removed. The intention was to shift users to calling react-native-community/cli directly. This change allows commands to be proxied to react-native-community/cli but with no guarantees of success. It's up to each framework / project to explicitly create that dependency. This also provides warnings, which won't go away, suggesting the supported method of calling the community CLI directly. The outcome is that we're not going to break existing workflows. closes: #45461 Changelog: [General][Fixed] allow proxying commands from react-native to react-native-community/cli with explicit warning Reviewed By: cortinico Differential Revision: D59805357 fbshipit-source-id: 21e23b082a9c709effa050d8e7dd04a40f5ab0e6
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previous work would cause versions >= react-native 0.76 to exit if called through
npx react-native <cmd>. This was intended to be full deprecated and removed. The intention was to shift users to calling react-native-community/cli directly.This change allows commands to be proxied to react-native-community/cli but with no guarantees of success. It's up to each framework / project to explicitly create that dependency.
This also provides warnings, which won't go away, suggesting the supported method of calling the community CLI directly.
The outcome is that we're not going to break existing workflows.
closes: #45461
Changelog: [General][Fixed] allow proxying commands from react-native to react-native-community/cli with explicit warning
Differential Revision: D59805357
Output:
Dependency ccli missing from project:
Dependency ccli included in project & command proxies successfully:
oject