-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
always proxy to @react-native-community/cli #45464
Conversation
This pull request was exported from Phabricator. Differential Revision: D59805357 |
Summary: Pull Request resolved: facebook#45464 Previous work would cause versions >= react-native 0.76 to exit if called through `npx react-native <cmd>`. This was intended to be full deprecated and removed. The intention was to shift users to calling react-native-community/cli directly. This change allows commands to be proxied to react-native-community/cli but with no guarantees of success. It's up to each framework / project to explicitly create that dependency. This also provides warnings, which won't go away, suggesting the supported method of calling the community CLI directly. The outcome is that we're not going to break existing workflows. closes: facebook#45461 Changelog: [General][Fixed] allow proxying commands from react-native to react-native-community/cli with explicit warning Differential Revision: D59805357
This pull request was exported from Phabricator. Differential Revision: D59805357 |
return; | ||
} | ||
|
||
console.warn(` | ||
${chalk.yellow('⚠')}️ The \`init\` command is deprecated. | ||
${chalk.yellow('🚨')}️ The \`init\` command is deprecated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I don't think you can color 🚨:
${chalk.yellow('🚨')}️ The \`init\` command is deprecated. | |
🚨 The \`init\` command is deprecated. |
Or you can, but it won't actually do anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this. You're right it's a total noop.
This pull request was successfully merged by @blakef in 9aed45a When will my fix make it into a release? | How to file a pick request? |
This pull request has been merged in 9aed45a. |
Summary: Pull Request resolved: #45464 Previous work would cause versions >= react-native 0.76 to exit if called through `npx react-native <cmd>`. This was intended to be full deprecated and removed. The intention was to shift users to calling react-native-community/cli directly. This change allows commands to be proxied to react-native-community/cli but with no guarantees of success. It's up to each framework / project to explicitly create that dependency. This also provides warnings, which won't go away, suggesting the supported method of calling the community CLI directly. The outcome is that we're not going to break existing workflows. closes: #45461 Changelog: [General][Fixed] allow proxying commands from react-native to react-native-community/cli with explicit warning Reviewed By: cortinico Differential Revision: D59805357 fbshipit-source-id: 21e23b082a9c709effa050d8e7dd04a40f5ab0e6
Summary:
Previous work would cause versions >= react-native 0.76 to exit if called through
npx react-native <cmd>
. This was intended to be full deprecated and removed. The intention was to shift users to calling react-native-community/cli directly.This change allows commands to be proxied to react-native-community/cli but with no guarantees of success. It's up to each framework / project to explicitly create that dependency.
This also provides warnings, which won't go away, suggesting the supported method of calling the community CLI directly.
The outcome is that we're not going to break existing workflows.
closes: #45461
Changelog: [General][Fixed] allow proxying commands from react-native to react-native-community/cli with explicit warning
Differential Revision: D59805357
Output:
Dependency ccli missing from project:
Dependency ccli included in project & command proxies successfully:
oject