Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bump deprecated glob@7 to supported glob@10 #45466

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

byCedric
Copy link
Contributor

@byCedric byCedric commented Jul 16, 2024

Summary:

glob@7 has been deprecated through npm, causing spammy deprecation warnings when installing React Native projects. This upgrades glob@7 to glob@10 (supporting at minimum Node 18) to get back on a supported glob version.

Changelog:

[GENERAL] [CHANGED] - Upgrade deprecated glob@7 to glob@10

Test Plan:

TBD

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner labels Jul 16, 2024
Copy link

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against faafc0c

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,451,101 -2
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,647,340 +8
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 5bb57eb
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants