Add support for longer tasks with explicit yielding in LongTask API #45471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
Base commit: c82edec |
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 16, 2024
…acebook#45471) Summary: Pull Request resolved: facebook#45471 Changelog: [internal] This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks. In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long". Check the new unit tests to see this behavior in practice. Reviewed By: sammy-SC Differential Revision: D55647992
3f29182
to
08baed4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
…acebook#45471) Summary: Pull Request resolved: facebook#45471 Changelog: [internal] This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks. In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long". Check the new unit tests to see this behavior in practice. Reviewed By: sammy-SC Differential Revision: D55647992
08baed4
to
c19aaf2
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
…acebook#45471) Summary: Pull Request resolved: facebook#45471 Changelog: [internal] This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks. In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long". Check the new unit tests to see this behavior in practice. Reviewed By: sammy-SC Differential Revision: D55647992
c19aaf2
to
a427995
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
…acebook#45471) Summary: Pull Request resolved: facebook#45471 Changelog: [internal] This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks. In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long". Check the new unit tests to see this behavior in practice. Reviewed By: sammy-SC Differential Revision: D55647992
a427995
to
74c63cf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
…acebook#45471) Summary: Pull Request resolved: facebook#45471 Changelog: [internal] This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks. In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long". Check the new unit tests to see this behavior in practice. Reviewed By: sammy-SC Differential Revision: D55647992
74c63cf
to
babdee3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
…acebook#45471) Summary: Pull Request resolved: facebook#45471 Changelog: [internal] This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks. In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long". Check the new unit tests to see this behavior in practice. Reviewed By: sammy-SC Differential Revision: D55647992
babdee3
to
149a1cf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
…acebook#45471) Summary: Pull Request resolved: facebook#45471 Changelog: [internal] This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks. In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long". Check the new unit tests to see this behavior in practice. Reviewed By: sammy-SC Differential Revision: D55647992
149a1cf
to
4f3c77d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
…acebook#45471) Summary: Pull Request resolved: facebook#45471 Changelog: [internal] This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks. In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long". Check the new unit tests to see this behavior in practice. Reviewed By: sammy-SC Differential Revision: D55647992
4f3c77d
to
55cdb30
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
…acebook#45471) Summary: Pull Request resolved: facebook#45471 Changelog: [internal] This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks. In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long". Check the new unit tests to see this behavior in practice. Reviewed By: sammy-SC Differential Revision: D55647992
55cdb30
to
8224c05
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
…acebook#45471) Summary: Pull Request resolved: facebook#45471 Changelog: [internal] This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks. In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long". Check the new unit tests to see this behavior in practice. Reviewed By: sammy-SC Differential Revision: D55647992
8224c05
to
ce82e65
Compare
Differential Revision: D59820241
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
ce82e65
to
a5ceb67
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 18, 2024
…acebook#45471) Summary: Pull Request resolved: facebook#45471 Changelog: [internal] This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks. In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long". Check the new unit tests to see this behavior in practice. Reviewed By: sammy-SC Differential Revision: D55647992
Differential Revision: D55491870
…acebook#45471) Summary: Pull Request resolved: facebook#45471 Changelog: [internal] This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks. In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long". Check the new unit tests to see this behavior in practice. Reviewed By: sammy-SC Differential Revision: D55647992
a5ceb67
to
ce4145e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55647992 |
|
This pull request has been merged in 15b8ac8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This is a React Native specific modification of the Long Tasks API that refines the logic to detect long tasks considering voluntary yielding checks.
In RN, as opposed to Web, we can have a very long task executing in the JS thread without causing any issues to the responsiveness of the app, as long as the task checks whether it should yield in short intervals. In this case, if the app always checks whether it should yield at least once every 50ms, the task will not be considered "long".
Check the new unit tests to see this behavior in practice.
Differential Revision: D55647992