-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Long Tasks API for PerformanceObserver #45473
Conversation
This pull request was exported from Phabricator. Differential Revision: D55491870 |
Base commit: c82edec |
This pull request was exported from Phabricator. Differential Revision: D55491870 |
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
a4418e0
to
d292852
Compare
This pull request was exported from Phabricator. Differential Revision: D55491870 |
d292852
to
b00e6ab
Compare
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
Summary: Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Differential Revision: D59820241
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
b00e6ab
to
462f08c
Compare
This pull request was exported from Phabricator. Differential Revision: D55491870 |
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
462f08c
to
0b0da04
Compare
This pull request was exported from Phabricator. Differential Revision: D55491870 |
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
This pull request was exported from Phabricator. Differential Revision: D55491870 |
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
0b0da04
to
d1a761a
Compare
This pull request was exported from Phabricator. Differential Revision: D55491870 |
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
d1a761a
to
253407f
Compare
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
This pull request was exported from Phabricator. Differential Revision: D55491870 |
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
This pull request was exported from Phabricator. Differential Revision: D55491870 |
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
822f80e
to
a1801ee
Compare
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
This pull request was exported from Phabricator. Differential Revision: D55491870 |
a1801ee
to
2b58c03
Compare
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
This pull request was exported from Phabricator. Differential Revision: D55491870 |
2b58c03
to
a4d4b87
Compare
This pull request was exported from Phabricator. Differential Revision: D55491870 |
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
a4d4b87
to
ad13000
Compare
Differential Revision: D59820241
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
This pull request was exported from Phabricator. Differential Revision: D55491870 |
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
ad13000
to
ff99fd1
Compare
Summary: Pull Request resolved: facebook#45473 This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/). It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled. This doesn't include attribution information at the moment. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D55491870
This pull request was exported from Phabricator. Differential Revision: D55491870 |
ff99fd1
to
de67637
Compare
Summary: Pull Request resolved: #45492 Changelog: [internal] When testing the changes in #45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241 fbshipit-source-id: c123920de56336da384ddc484f6ac9d287724301
This pull request has been merged in 64c4e38. |
Summary:
This is a basic implementation of the Long Tasks API (https://w3c.github.io/longtasks/).
It detects and reports long tasks when using the Event Loop (in the modern RuntimeScheduler) when a new feature flag for this purpose is enabled.
This doesn't include attribution information at the moment.
Changelog: [internal]
Reviewed By: sammy-SC
Differential Revision: D55491870