-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove _shouldEmitEvent
guardrails
#45476
Conversation
This pull request was exported from Phabricator. Differential Revision: D59811656 |
Base commit: dbbb406 |
This pull request was exported from Phabricator. Differential Revision: D59811656 |
934cec5
to
7e8e903
Compare
Summary: Pull Request resolved: facebook#45476 Land this after [facebook#45457](facebook#45457) lands. After [facebook#45457](facebook#45457) there is no need to check for listeners to the native event as we will have those listeners for sure. ## Changelog [Internal] - Remove `_shouldEmitEvent` guardrails as we always have listeners Reviewed By: sammy-SC Differential Revision: D59811656
7e8e903
to
740c75d
Compare
Summary: Pull Request resolved: facebook#45476 Land this after [facebook#45457](facebook#45457) lands. After [facebook#45457](facebook#45457) there is no need to check for listeners to the native event as we will have those listeners for sure. ## Changelog [Internal] - Remove `_shouldEmitEvent` guardrails as we always have listeners Reviewed By: sammy-SC Differential Revision: D59811656
This pull request was exported from Phabricator. Differential Revision: D59811656 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D59811656 |
740c75d
to
8a17143
Compare
Summary: Pull Request resolved: facebook#45476 Land this after [facebook#45457](facebook#45457) lands. After [facebook#45457](facebook#45457) there is no need to check for listeners to the native event as we will have those listeners for sure. ## Changelog [Internal] - Remove `_shouldEmitEvent` guardrails as we always have listeners Reviewed By: sammy-SC Differential Revision: D59811656
This pull request was exported from Phabricator. Differential Revision: D59811656 |
8a17143
to
1f17df8
Compare
Summary: Pull Request resolved: facebook#45476 Land this after [facebook#45457](facebook#45457) lands. After [facebook#45457](facebook#45457) there is no need to check for listeners to the native event as we will have those listeners for sure. ## Changelog [Internal] - Remove `_shouldEmitEvent` guardrails as we always have listeners Reviewed By: sammy-SC Differential Revision: D59811656
Summary: Pull Request resolved: facebook#45414 This change completes the fix for broken pressable when animations were applied to components with native driven animations. When creating the AnimatedProps, if they are natively drive animation, we look for the AnimatedValue involved and we register a listener. This is needed to make sure that the NativeModule will send te updated value upon calling the `update` function. Then, when observing the props lifecycle, it register a listener to the new `OnUserAnimationEnded` event, fired by the NativeAnimation module. When the `OnUserAnimationEnded` event is fired, the AnimatedProps will update the props that depends on the user driven animation. ## Changelog [General][Fixed] - reallign the shadow tree and the native tree when the user finishes interacting with the app. Differential Revision: D59681428
Summary: Pull Request resolved: facebook#45476 Land this after [facebook#45457](facebook#45457) lands. After [facebook#45457](facebook#45457) there is no need to check for listeners to the native event as we will have those listeners for sure. ## Changelog [Internal] - Remove `_shouldEmitEvent` guardrails as we always have listeners Reviewed By: sammy-SC Differential Revision: D59811656
This pull request was exported from Phabricator. Differential Revision: D59811656 |
1f17df8
to
79cca30
Compare
This pull request has been merged in dae9c5c. |
Summary:
Land this after #45457 lands.
After #45457 there is no need to check for listeners to the native event as we will have those listeners for sure.
Changelog
[Internal] - Remove
_shouldEmitEvent
guardrails as we always have listenersDifferential Revision: D59811656