Move timing definitions to a specific target #45492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D59820241 |
|
This pull request was exported from Phabricator. Differential Revision: D59820241 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
b2ffa50
to
08b8c19
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
08b8c19
to
a73cbb9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59820241 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D59820241 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
a73cbb9
to
49c2437
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59820241 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
49c2437
to
6ea5f2a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59820241 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
6ea5f2a
to
c3722ac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59820241 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
c3722ac
to
7dab8ca
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
7dab8ca
to
07066a5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59820241 |
Base commit: c82edec |
|
This pull request was exported from Phabricator. Differential Revision: D59820241 |
07066a5
to
a81e93c
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 17, 2024
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
Summary: Pull Request resolved: facebook#45492 Changelog: [internal] When testing the changes in facebook#45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto). Taking a closer look, I realized that I wasn't doing the conversion between times and durations from `chrono` and `DOMHighResTimeStamp` (a `double`) correctly, and we're doing this conversion very often. This moves the definition of `DOMHighResTimeStamp` to its own library and adds conversion methods to make sure we don't make this mistake in the future. Reviewed By: rshest Differential Revision: D59820241
|
This pull request was exported from Phabricator. Differential Revision: D59820241 |
a81e93c
to
9bf1451
Compare
|
This pull request has been merged in dffc156. |
|
This pull request was successfully merged by @rubennorte in dffc156 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
When testing the changes in #45473 / D55491870, I saw that the reported time spans for long tasks didn't perfectly align with the long tasks themselves in traces (Perfetto).
Taking a closer look, I realized that I wasn't doing the conversion between times and durations from
chronoandDOMHighResTimeStamp(adouble) correctly, and we're doing this conversion very often.This moves the definition of
DOMHighResTimeStampto its own library and adds conversion methods to make sure we don't make this mistake in the future.Differential Revision: D59820241