Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RN][CI] Factor out build npm package #45493

Closed
wants to merge 1 commit into from
Closed

[RN][CI] Factor out build npm package #45493

wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

Summary:

Factor out the Build NPM package job in a separate action for code reuse

Changelog:

[Internal] - Factor out the Build NPM package job in a separate action for code reuse

Test Plan:

GHA are green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 17, 2024
@cipolleschi cipolleschi force-pushed the cipolleschi/factor-out-build-npm branch 6 times, most recently from e02ecb8 to 9889448 Compare July 17, 2024 13:11
@cipolleschi cipolleschi marked this pull request as ready for review July 17, 2024 13:11
@cipolleschi cipolleschi force-pushed the cipolleschi/factor-out-build-npm branch from 9889448 to 46ff7f8 Compare July 17, 2024 13:12
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented Jul 17, 2024 •
edited

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 21,353,611 -1,245
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 24,549,454 -537
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fcd526d
Branch: main

@cipolleschi cipolleschi force-pushed the cipolleschi/factor-out-build-npm branch from 46ff7f8 to 045791b Compare July 18, 2024 10:14
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/factor-out-build-npm branch from 045791b to b66b868 Compare July 18, 2024 10:27
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi cipolleschi force-pushed the cipolleschi/factor-out-build-npm branch from b66b868 to 1c5f3ae Compare July 18, 2024 12:28
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 18, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 3294326.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cipolleschi in 3294326

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cipolleschi @facebook-github-bot @analysis-bot @react-native-bot