-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli will report "Couldn't find cargo" when it can't find powershell #314
Comments
What do you mean by can't find powershell? Are you running Also what happens when you just run |
Actually, Perseus does require Powershell! For most commands, because there can be all sorts of issues with I'd be happy to add a preflight check that makes sure we can actually run commands at all, which is probably a good idea! @raspirin what shell do you regularly use? Right now, from the sounds of things, the CLI is hardcoded to not work for you... |
Well, I'm not familiar with Windows and Powershell either. I use Fish on Linux. |
Huh, that is weird. That sounds like a configuration-specific issue somewhere in Windows, but I've just added that pre-flight check. Try downloading the latest development version of the Perseus CLI ( We could certainly try getting Perseus to work without depending on a shell, but as I said, there are historical reasons for that, because v0.1.0 had all sorts of problems on Windows that were solved by using a shell. |
Actually this check seems to have broken every single test, give me a moment... |
Okay, I've completely removed the use of shells in the CLI for now, which seems to work well, at least locally and on CI. @raspirin can you confirm this works for you on a Windows box when you next can? Happy to cut a new release if it's all working for you. (I.e. even without Powershell in your |
Good news, the cli won't report "Couldn't find cargo" with and without
I could manually run wasm-bindgen using the location above though. Then I added I notice that the wasm-bindgen path is weird. It's not a completely windows-style path. |
Hmm, that command doesn't look right at all, let me see if tool execution is still depending on the shell somehow... |
@raspirin I've created a new branch |
Sure. I will try this next weekend. |
Sorry for the long delay. It's been a lot last couple of months.
|
Maybe try with |
Hello. "&" seems to be a valid operator in Powershell (never used powershell, so no idea what it does, but it doesn"t throw an error), while it's not in the regular command prompt. ( install.rs, two lines with "let (wb_path, wo_path) = (format!" in it . ) |
Oh! Very greatly appreciated! I'll update the branch with this and then could you confirm the CLI works for you @raspirin? |
Hi. Also note that you still depend on powershell for the function run_cmd_directly in cmd.rs . |
This issue is reporting a bug in the code of Perseus. Details of the scope will be available in issue labels.
The author described their issue as follows:
The steps to reproduce this issue are as follows:
A minimum reproducible example is available at <>.
Tribble internal data
dHJpYmJsZS1yZXBvcnRlZCxDLWJ1ZyxBLWNsaQ==
The text was updated successfully, but these errors were encountered: