Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move existing client back to current namespace #811

Closed
daniel-sanche opened this issue Jun 23, 2023 · 0 comments
Closed

move existing client back to current namespace #811

daniel-sanche opened this issue Jun 23, 2023 · 0 comments
Assignees
@daniel-sanche
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern.
Milestone
v3-alpha

Comments

@daniel-sanche
Copy link
Contributor

At the start of v3 development, I moved the existing client into google.cloud.bigtable.deprecated. For the alpha, we'll need it to be back in it's original namespace.

The new client should be moved to google.cloud.bigtable.data to avoid name collisions with duplicated model classes

Along with this change, we should make sure required public classes are suffixed with Async
@daniel-sanche daniel-sanche added type: cleanup An internal cleanup or hygiene concern. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 23, 2023
@daniel-sanche daniel-sanche added this to the v3-alpha milestone Jun 23, 2023
@daniel-sanche daniel-sanche self-assigned this Jun 23, 2023
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Jun 23, 2023
@daniel-sanche daniel-sanche mentioned this issue Jun 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
v3-alpha
Development

No branches or pull requests
1 participant
@daniel-sanche