Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make custom error for extra rows #853

Closed
daniel-sanche opened this issue Aug 14, 2023 · 1 comment
Closed

Make custom error for extra rows #853

daniel-sanche opened this issue Aug 14, 2023 · 1 comment
Assignees
@daniel-sanche
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
v3-GA

Comments

@daniel-sanche
Copy link
Contributor

We raise a RuntimeError if we encounter rows > row_limit. We should probably emit a custom exception type, or otherwise make the error more understandable

From @igorbernstein2 in #852 (comment)_
@daniel-sanche daniel-sanche added this to the v3-beta milestone Aug 14, 2023
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Aug 14, 2023
@daniel-sanche daniel-sanche self-assigned this Aug 14, 2023
@daniel-sanche daniel-sanche added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Aug 14, 2023
@daniel-sanche daniel-sanche mentioned this issue Aug 14, 2023
Merged
@daniel-sanche daniel-sanche modified the milestones: v3-beta, v3-alpha-2 Sep 18, 2023
@daniel-sanche daniel-sanche modified the milestones: v3-alpha-2, v3-beta Sep 27, 2023
@daniel-sanche
Copy link
Contributor Author

Is this still relevant after our latest performance refactors?

@kolea2 kolea2 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: bigtable Issues related to the googleapis/python-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
v3-GA
Development

No branches or pull requests
2 participants
@daniel-sanche @kolea2