Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jackson versions and vulnerabilities #17444

Closed
alkoclick opened this issue Sep 1, 2020 · 16 comments
Closed

Jackson versions and vulnerabilities #17444

alkoclick opened this issue Sep 1, 2020 · 16 comments
Assignees
Labels
Source: Community PR or issue was opened by a community user Team: Core Type: Defect
Milestone

Comments

@alkoclick
Copy link

alkoclick commented Sep 1, 2020

Hey folks,

Hazelcast shades Jackson 2.9.7, which currently is about 2 years old. There's a lot of Jackson CVEs out there (FasterXML/jackson-databind#2814 is the latest that popped up for us), often centered around gadgets, as explained by cowtowncoder (primary Jackson maintainer) himself in this medium article.

It is possible that Hazelcast is affected by CVE-2020-24616, though it looks unlikely to me, you don't seem to be using Anteros-DBCP. It is possible that Hazelcast is affected by one of the other Jackson-targeting CVEs, which I could see being exploited in ways similar to #802.

Nevertheless and since this is a 2 y.o version anyway, would it be a reasonable goal to switch to a newer version such as 2.11 and resolve both these issues?

@mmedenjak mmedenjak added Source: Community PR or issue was opened by a community user Team: Core labels Sep 2, 2020
@mmedenjak
Copy link
Contributor

Hi @alkoclick ! Yes, you're right. We should definitely take a look. Unfortunately, this issue comes at a both unfortunate and opportune time when we're finalising a new release. We don't want to introduce too many changes and would prefer to stabilise the codebase. Still, it seems this is important. So I'll put this in the current milestone and see if it's simple to achieve and not too disruptive.

@mmedenjak mmedenjak added this to the 4.1 milestone Sep 2, 2020
@melloware
Copy link

OWASP dependency-check-maven plugin is reporting this as of this week blocking builds.

hazelcast-4.0.2.jar/META-INF/maven/com.fasterxml.jackson.core/jackson-core/pom.xml (pkg:maven/com.fasterxml.jackson.core/[email protected], cpe:2.3:a:fasterxml:jackson:2.9.7:*:*:*:*:*:*:*) : CVE-2020-24616
hazelcast-4.0.2.jar/META-INF/maven/org.snakeyaml/snakeyaml-engine/pom.xml (pkg:maven/org.snakeyaml/[email protected], cpe:2.3:a:snakeyaml_project:snakeyaml:1.0:*:*:*:*:*:*:*) : CVE-2017-18640

@a1dutch
Copy link

a1dutch commented Sep 4, 2020

@mmedenjak can this be backported to 3.12.x?

@mmedenjak
Copy link
Contributor

Depends on the extent of changes introduced by this. We have compatibility guarantees that we are not supposed to break in minor releases, although some might be ignored if the vulnerability is severe.

@mmedenjak
Copy link
Contributor

@melloware @a1dutch we just merged #17484, which bumps the jackson dependency to 2.11.2 which fixesCVE-2020-24616.

We also merged #17446 which bumped SnakeYAML to 2.1, which fixes CVE-2017-18640.

This was for the 4.1 mainline, I'll backport to the 4.0.z and 3.12.z branches, although for 3.12 I'll have to see if these upgrades are JDK6 compatible.

@melloware
Copy link

Fantastic news. Once released we will upgrade to 4.0.3!

@mmedenjak
Copy link
Contributor

The fixes have now been merged to the upcoming 4.1, 4.0.3 and 3.12.10 releases. Closing, thank you for the report and the PRs!

@melloware
Copy link

melloware commented Sep 9, 2020

@mmedenjak I am still getting this error with OWASP plugin and hazelcast-4.1-BETA-1:

CVE-2017-18640
hazelcast-4.1-BETA-1.jar/META-INF/maven/org.snakeyaml/snakeyaml-engine/pom.xml (pkg:maven/org.snakeyaml/[email protected], cpe:2.3:a:snakeyaml_project:snakeyaml:1.0:*:*:*:*:*:*:*) : CVE-2017-18640

@mmedenjak
Copy link
Contributor

mmedenjak commented Sep 9, 2020

BETA-1 hasn't received the fix as the fix came in quite late and we already ran release verification tests for the BETA release. It will be in 4.1-GA, which will be released in about a month or two. We don't recommend BETA releases for production anyway so I think it's ok.

@a1dutch
Copy link

a1dutch commented Sep 10, 2020

@mmedenjak is there any timeframe on when the releases will take place?

Our deployments are currently blocked until the vulnerabilities are fixed.

@mmedenjak
Copy link
Contributor

4.1-GA will be out around late October and both 4.0.3 and 3.12.10 might be out in several weeks. By then, if you really need to progress with your deployments, you can depend on the SNAPSHOT versions of 4.0.3-SNAPSHOT and 4.1-SNAPSHOT as both should be stabler than the BETA release already.

@a1dutch
Copy link

a1dutch commented Sep 10, 2020

We cannot use Snapshots I'm afraid. What about 3.12? Any chance of a release just with the updated shaded jars?

@mmedenjak
Copy link
Contributor

It will all be released in due time, as mentioned.

@alkoclick
Copy link
Author

@mmedenjak Thanks a lot for the hard work on delivering this under such a tight schedule!

@a1dutch I would recommend ignoring this in your vulnerability scanner until the new versions are out. As I point out in my original post, CVE-2020-24616 does not seem to affect Hazelcast anyway.

@mmedenjak
Copy link
Contributor

An update - we've started the release process for 4.0.3, it should be out some time next week.

@mmedenjak mmedenjak modified the milestones: 4.1, 3.12.10 Sep 11, 2020
@mmedenjak
Copy link
Contributor

Hazelcast 4.0.3 was released yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source: Community PR or issue was opened by a community user Team: Core Type: Defect
Projects
None yet
Development

No branches or pull requests

4 participants