Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReGaHss/WebUI: Option for all WebUI programs to suppress automatic start upon start of ReGaHss #223

Open
jens-maus opened this issue Dec 26, 2017 · 9 comments
Labels
💡 enhancement-ideas New feature or change request 🏷️ ReGaHss This refs the ReGaHss component 🏷️ WebUI This refs the WebUI component

Comments

@jens-maus
Copy link
Owner

When ReGaHss is started/restarted all defined programs are automatically executed. However, this usually results in unwanted side effects (e.g. high DutyCycle due to high amount of communications). Therefore, it would probably be a good idea to add a possibility to suppress the automatic start of a program if ReGaHss is started and wait until it is properly started and the actual condition becomes true. This could either be arranged by adding an addition checkbox to select the programs which should be executed automatically or by letting all programs wait until their execution conditions are actually true for the first time.

@jens-maus jens-maus added 💡 enhancement-ideas New feature or change request 🏷️ ReGaHss This refs the ReGaHss component 🏷️ WebUI This refs the WebUI component labels Dec 26, 2017
@litti
Copy link

litti commented Dec 27, 2017

I think adding a checkbox to select the programs which should be run at the start would be the best and more compatible solution. I use the fact that programs run at startup for setting some things.

@jens-maus
Copy link
Owner Author

Thanks for the comments. But shouldn't it be also possible to not provide a checkbox but let only programs without any conditions to be immediately be executed. That means, one can then still create programs without any conditions and they will be immediately executed upon ReGaHss start. And only programs with conditions will be scheduled to be executed only if the conditions are true.

@litti
Copy link

litti commented Dec 27, 2017

Today the programs are executed and the conditions are taken into account if the system starts. E. g. system variables are set to the right state (e. g. "morgens", "mittags", "abends" depending on the time). If there would be no checkbox for this program this would mean that this variable will only have the right time after the next point of time when the program is executed not when the system is started. It would not be possible to create the right status because a program without condition would not be suitable (to which state should it set the system variable to without having a condition). I think having the checkbox would be the best option - active by default to be run at startup to set all states to what they should be. Programs without conditions are run at startup even today. So there would be four options: Program with conditions without checkbox set: not run at startup even if conditions are true; program with conditions with checkbox set: run at startup if conditions are met; program without conditions without checkbox: doesn't run at startup only on manual start trigger, e. g. via webui; and the forth: programs without conditions with checkbox set: run at every startup or manual trigger.

@mifricke
Copy link

A checkbox will be quite useful, but i think, it has to work the other way. Automatic starting of programs on reboot should be disabled as default. Only if a special program needs to be startet on reboot, a checkbox should be there to allow it. Most programs don't need to run on reboot. In my case only three or four programs.

@jens-maus
Copy link
Owner Author

This is more or less the current plan. However, I will have to probably enable it by default when switching to the first version supporting this feature or otherwise existing programs won't run as expected anymore once the new version is installed.

@Maik2208
Copy link
Contributor

Maik2208 commented Mar 1, 2021

Gibt es hier nach drei Jahren einen neuen Stand?

So eine Checkbox wäre wirklich super und dürfte auch nicht soo den riesigen Aufwand bedeuten!?

@jp112sdl
Copy link
Contributor

jp112sdl commented Mar 2, 2021

dürfte auch nicht soo den riesigen Aufwand bedeuten!?

Ich mag solche Einschätzungen immer sehr 🙄
Wie viele Checkboxen hast du schon der WebUI hinzugefügt? 😁

@Maik2208
Copy link
Contributor

Maik2208 commented Mar 2, 2021

Wie du an dem !? erkennst, wollte ich mich tatsächlich nicht ganz festlegen 😬

In der WebUI leider noch gar keine. Ich bin zu der persönlichen Einschätzung gekommen, da ich selbst programmiere und für mich vereinfacht (!!) gesagt eine Checkbox und eine IF-Abfrage überschaubaren Aufwand bedeutet. Ihr habt da schon ganz andere Dinge in kürzester Zeit aus dem Boden gezogen, auf die ihr wirklich stolz sein könnt 💪🏻

Ich würde ja auch anbieten, dass ich mir die Sache mal ansehe. Scheint ja kein Zeitdruck zu herrschen 😉
Ich müsste dann nur irgendwie abgeholt werden. Ich habe bisher keine Ahnung an welcher Ecke ich die anzupassenden Stellen finde und wie ich das Ganze updatesicher umsetze.

@Maik2208
Copy link
Contributor

Maik2208 commented Jul 5, 2022

Ich hole dieses Dingen nochmal aus dem Keller, da mir noch immer sehr viel an der Umsetzung liegt.

Es gehört zu den Dingen, die mich am meisten an der HM nerven...

Gibt es inzwischen Umsetzungspläne? :)

@github-actions github-actions bot added the 🧊 stale Ticket is in a stale state (about to be closed) label Sep 7, 2023
@jens-maus jens-maus removed the 🧊 stale Ticket is in a stale state (about to be closed) label Sep 7, 2023
@jens-maus jens-maus added this to the future release milestone Sep 7, 2023
Repository owner deleted a comment from github-actions bot Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 enhancement-ideas New feature or change request 🏷️ ReGaHss This refs the ReGaHss component 🏷️ WebUI This refs the WebUI component
Projects
Development

No branches or pull requests

5 participants