Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PromoBannerv2] Allow to pass icon and iconPosition properties to component's buttons #1081

Closed
quarties opened this issue Apr 11, 2024 · 1 comment
Labels
feature New feature or request

Comments

@quarties
Copy link
Contributor

Description

Currently, only 3 following Button component properties are available to pass in the PromoBannerV2 component:

  /**
   * Shows the primary CTA button
   */
  primaryButton?: {
    handleClick: () => void;
    label: string;
    kind?: ButtonKind;
  };

We additionally need to pass the icon and iconPosition properties. Also, it would be nice to have all possible properties supported here out of the box.

Design

image
@quarties quarties added the feature New feature or request label Apr 11, 2024
@vladko-uxds
Copy link

Duplicates by
#873

@vladko-uxds vladko-uxds closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Development

No branches or pull requests

2 participants