-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Nextcloud to latest v27 #2399
Comments
8.0 is marked as deprecated; not removed. We can upgrade to 27. In fact I’ve been running on it for months. There is another gotcha for the upgrade. File permissions need to be adjusted when deploying the release. |
I see. Hmmm. Still, deprecation warnings shouldn't be ignored. And one day we will want to upgrade to v28 anyway ...
Oh? Any more information on this? Is that difficult? Do we have a PR for this? |
Definitely, but with a security issue present we probably should get that out of the way first. Several years ago I did the work to get us to a ppa for php_next (can't remember the version) we can probably reuse much of that work.
Pretty simple fix really, took a while to figure it out though... nextcloud now requires the deployed files to have write permissions by the webserver user otherwise the upgrade via occ can't proceed. This commit solves that on my fork. My fork can't be directly merged since I run some nextcloud customizations that would cause conflicts, but it's not much. So a quick merge should be possible. yodax@1aaf0fb Here is the full diff We can ignore the phone number stuff and the manual updates to the calendar and contacts components. I believe the calendar updates is required for v27. |
Thanks, mate
Do you think you could do a PR for this for a first step?
Uh, many of us MiaB users still access Nextcloud with |
No sorry, I don't have the time. I can provide guidance when someone runs into problems. |
Okay, Respekt: |
The write issues are required for v27. So I'd suggest doing the upgrade to the latest v27 with the write issue as well since you can't upgrade without that fix. Then do the php ppa upgrade. Then the upgrade to nextcloud vnext. |
@yodax Tell me, the new v69 has this update: Does that include the PHP writing issue fix? |
That message refers to commit #2377 which only fixes the syntax of a chown command specific to nextcloud |
Thanks, all clear. Then that's not related to the "nextcloud now requires the deployed files to have write permissions by the webserver" issue Yodax mentioned further above? Or am I wrong? |
I took this to be one and the same. |
Sorry, I do not follow. Is that a yes or no? |
The commit #2377 by @jvolkenant fixes the chown part of @yodax commit yodax@1aaf0fb
I believe it is only the chown command that is needed to fix this, not the chmod. Happy for @yodax or anyone else to chime in. |
I found that the access rights changes were necessary. It was reported during the occ commands that they needed to be changed. Regardless, when someone does the actual upgrade, it will be pretty clear if it's needed since it will fail with an error message telling you that this needs changing. Looking at the original code I should've placed my changes next to the original chown's. I'll merge that into my branch later. |
@yodax please do soon and LMK - I'm keen to move on, to upgrade PHP and NC next. So gotta be sure, all is sorted about any permission issues. |
There’s no need to update my fork. It’s already diverged. I’ll fix it when I update Nextcloud. |
Because new Nextcloud vulnerabilities have been reported and look scary, we should consider upgrading Nextcloud from the current v26 to the latest v27 and ensure it truly fixes that vulnerability.
But such a PR would depend on upgrading to PHP v8.1 first, which is covered in the other ticket (dependency):
#2398
Make sure all is exactly covered as precisely documented in this migration guide:
docs.nextcloud.com/server/latest/admin_manual/release_notes/upgrade_to_27.html
The text was updated successfully, but these errors were encountered: