Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGC: Mission Edit problems. #3456

Open
tubeme opened this issue Jun 1, 2016 · 26 comments
Open

QGC: Mission Edit problems. #3456

tubeme opened this issue Jun 1, 2016 · 26 comments
Assignees

Comments

@tubeme
Copy link

tubeme commented Jun 1, 2016

Hello everybody,

Just to report some problems when programming large missions.

In the bottom bar, where I get info on the alt and distance of waypoint, there is no way I could see after point 58. Probably this number depends on the resolution. I'm fullHD so 58 points :)

Also when the waypoints on the right, fill the height of the window, each new waypoint is hidden, under the window so you cannot see the height of the waypoint except when you move the mouse and slide the waypoints.

You can see:

mission sapareva

Also when you make new waypoints it did not remember the height from the previous one if you made some corrections. When you make corrections to a waypoint height you have to explicitly hit TAB in order to move the focus on another box. Then it remembers the previous waypoint and places its altitude as height value.

@DonLakeFlyer DonLakeFlyer self-assigned this Jun 1, 2016
@DonLakeFlyer DonLakeFlyer added this to the Release v3.0 milestone Jun 1, 2016
@DonLakeFlyer
Copy link
Contributor

Height map athe the bottom should be left/right scrollable with the mouse.

@NaterGator
Copy link
Contributor

@DonLakeFlyer I think maybe @tubeme is suggesting we scroll that flickable to the inserted item's position too.

@DonLakeFlyer
Copy link
Contributor

Ah, good point.

NaterGator added a commit to NaterGator/qgroundcontrol that referenced this issue Jun 1, 2016
@tubeme
Copy link
Author

tubeme commented Jun 1, 2016

@DonLakeFlyer It is good when you have mouse, but on the field I don't use one... Also I want to see at this bar and on the right waypoints ribbon the current waypoint that I'm editing now. It was hell to set up this 78 point mission...

@NaterGator
Copy link
Contributor

@DonLakeFlyer is there a reason we can add onValueChanged handling here? Obviously we should use the validator in a non-intrusive way so that we don't set invalid values to the fact and don't prevent the user from continuing to edit the field to fix the value.

That would address @tubeme's other outstanding concern.

@DonLakeFlyer
Copy link
Contributor

It is good when you have mouse, but on the field I don't use one

How do you use QGC without a mouse? How are you selecting things? You can scroll with the a trackpad or touch as well.

@DonLakeFlyer
Copy link
Contributor

Also when you make new waypoints it did not remember the height from the previous one if you made some corrections. When you make corrections to a waypoint height you have to explicitly hit TAB in order to move the focus on another box. Then it remembers the previous waypoint and places its altitude as height value.

Arae you saying that the waypoint height change is not being saved but gets lost? Or just that the use a previous altitude for new waypoints thing is not working. Or both?

@DonLakeFlyer
Copy link
Contributor

@NaterGator I don't quite understand what you are getting at? What do you want to do in onValueChanged?

@NaterGator
Copy link
Contributor

@NaterGator I don't quite understand what you are getting at? What do you want to do in onValueChanged?

I was referencing this:

Also when you make new waypoints it did not remember the height from the previous one if you made some corrections. When you make corrections to a waypoint height you have to explicitly hit TAB in order to move the focus on another box. Then it remembers the previous waypoint and places its altitude as height value.

What he's talking about is typing in a value in the altitude fact text field and then not hitting enter before dropping another point. valueChanged signal fires continuously as data is entered, editingFinished is fired when focus is lost or enter is pressed.

@DonLakeFlyer
Copy link
Contributor

Ok I get it now. What I think needs to happen is that I need to figure out how to get focus to work correctly. When you click in the map to add a new waypoint or click a toolbutton the focus should leave the previous control but it didn't. If the focus left, it would also finish the edit.

@tubeme
Copy link
Author

tubeme commented Jun 2, 2016

@DonLakeFlyer

How do you use QGC without a mouse? How are you selecting things? You can scroll with the a trackpad or touch as well.

I'm using it in the most simple way. By clicking on the buttons, holding and then drag with the pad. I select things by the buttons of the pad. I don't use the scroll function of the pad, because some of my laptops have it some don't So i don't bother to install the drivers for the pad and thus no scrolling.

If the bottom bar with the waypoint heights is scroll-able, there should be an indication for this, and probably some left and right arrows to move around if you don't use scroll function.

@tubeme
Copy link
Author

tubeme commented Jun 2, 2016

@DonLakeFlyer

Arae you saying that the waypoint height change is not being saved but gets lost? Or just that the use a previous altitude for new waypoints thing is not working. Or both?

It is hard to explain but I will try.

I have a mission programmed. I'm on the Waypoint 20. Until now the points were programmed at 100 meters. from 20 I want to rase the altitude with 40 meters. So I create waypoint 20 and in the Altitude dialog I change the altitude to 140 meters, then after the edit the cursor is active and blinking in the altitude text box. SO if i dont hit TAB after the edit to 140, in order to remove the cursor from the altitude text box, and in this condition I create a new wayipoint 21, it will be with default altitude of 100 meters, like it did not remember my edit in the waypoint 20 but rather uses the preset altitude of point 19. Actually i tried to hit enter after i make the edit to 140 but it did not solve the problem. The only way around is hitting TAB and removing the focus on the altitude text box.

Is it understandable now?

@tubeme
Copy link
Author

tubeme commented Jun 2, 2016

@NaterGator

What he's talking about is typing in a value in the altitude fact text field and then not hitting enter before dropping another point. valueChanged signal fires continuously as data is entered, editingFinished is fired when focus is lost or enter is pressed.

Enter does not work! Only TAB.

@DonLakeFlyer
Copy link
Contributor

If the bottom bar with the waypoint heights is scroll-able, there should be an indication for this, and probably some left and right arrows to move around if you don't use scroll function.

Just click and drag it to scroll.

@tubeme
Copy link
Author

tubeme commented Jun 2, 2016

I don't really like the waypoint ribbon at right of the screen. It is very cumborsome to use. I loose my focus going back and forth. When I have to make large missions with lots of changes in the altitude etc, I have to move back and forth between selecting waypoints for edit and the boxes on the right. Why not hide all this boxes. And when you click on a waypoint, show me the box of the waypoint right at my mouse click right beside the waypoint. IE when you make waypoint active for edit just show me the altitude dialog at the map. Then hide it. There is no point in this ribbon at right:

better

What kind of information i get from this to help me get at one glance my flight plan??

ribbon

It just takes place from my map. This is on FullHD res imagine if I have a smaller display...

@tubeme
Copy link
Author

tubeme commented Jun 2, 2016

This could be much more valuable to me as a pilot if the ribbon is there to stay.

info

Then on edit you have the menu with more options.

@tubeme
Copy link
Author

tubeme commented Jun 2, 2016

@DonLakeFlyer

Just click and drag it to scroll.

Thanks it works this way... Did not know it. Probably if it kept the focus to the last point and moved away the first points I could have tried to scroll it...

@DonLakeFlyer
Copy link
Contributor

Probably if it kept the focus to the last point and moved away the first points I could have tried to scroll it...

Nate has the fix for that I hope.

Can you enter usability problems into a separate Issue? Let's keep this one just for bugs.

@tubeme
Copy link
Author

tubeme commented Jun 2, 2016

OK.

@tubeme
Copy link
Author

tubeme commented Jun 2, 2016

Sorry for my usability comments. I just have it as one experience on the airfield some bugs plus some usability problems...

@DonLakeFlyer
Copy link
Contributor

Sorry for my usability comments.

Please keep them coming! Nothing gets better without people complaining. Just don't want them to get lost.

NaterGator added a commit to NaterGator/qgroundcontrol that referenced this issue Jun 2, 2016
@DonLakeFlyer
Copy link
Contributor

The "not hitting enter" problem is going to have to push to 3.1. At this point I'm not quite sure how to fix it. But it's a larger issue that shows up in other parts of the ui as well.

@DonLakeFlyer DonLakeFlyer modified the milestones: Release V3.2, Release V3.1 Nov 11, 2016
@DonLakeFlyer
Copy link
Contributor

The "not hitting enter" problem is going to have to push to 3.1.

FYI: This is fixed now.

@DonLakeFlyer
Copy link
Contributor

If the bottom bar with the waypoint heights is scroll-able, there should be an indication for this, and probably some left and right arrows to move around if you don't use scroll function.

There are scroll indicators which show up no these and then go away. Also it auto-scrolls to the newly added items now.

@DonLakeFlyer
Copy link
Contributor

I think most of this is better now. Except for the right panel thing. In general I agree that the format is not that great. But not something we'll tackle now.

@DonLakeFlyer DonLakeFlyer modified the milestones: Release v3.3, Release V3.2 Apr 13, 2017
@DonLakeFlyer
Copy link
Contributor

Pulling this from above, since it's a great idea:
70c3d892-28ff-11e6-9c70-1424a5616750

@DonLakeFlyer DonLakeFlyer modified the milestones: Release v3.3, Release v3.4 Dec 29, 2017
@DonLakeFlyer DonLakeFlyer removed this from the Release v3.4 milestone Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants