Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Use Array.includes instead of index checking #42826

Closed
DiegoAndai opened this issue Jul 2, 2024 · 0 comments · Fixed by #42883
Closed

[core] Use Array.includes instead of index checking #42826

DiegoAndai opened this issue Jul 2, 2024 · 0 comments · Fixed by #42883
Assignees
@DiegoAndai
Labels
enhancement This is not a bug, nor a new feature ready to take Help wanted. Guidance available. There is a high chance the change will be accepted

Comments

@DiegoAndai
Copy link
Member

DiegoAndai commented Jul 2, 2024 •
edited

Follow up of #42283 (comment)

Dropping IE 11 support (#14420) allows us to replace Array.indexOf('some string') [===|!==] -1 as a substitute for Array.includes. This issue is to track this refactor.

#42283 (comment) for a list of the Material UI-specific ones.

Search keywords: array includes
@DiegoAndai DiegoAndai added ready to take Help wanted. Guidance available. There is a high chance the change will be accepted enhancement This is not a bug, nor a new feature labels Jul 2, 2024
@DiegoAndai DiegoAndai self-assigned this Jul 2, 2024
@k-rajat19 k-rajat19 mentioned this issue Jul 7, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DiegoAndai DiegoAndai

Labels
enhancement This is not a bug, nor a new feature ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] Replace indexOf with includes k-rajat19/material-ui
1 participant
@DiegoAndai