-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][breakpoints] Add ultra-wide breakpoint #42860
base: master
Are you sure you want to change the base?
Conversation
Note This comment is out of date, please see comment below Hi @siriwatknp & @brijeshb42 (sorry if tagged wrong people, just look at Git file history). I have a question regarding the Pigment CSS package which is causing this PR to fail in the Essentially, the Error:
I've tried to update the Pigment CSS package with the new Any advice on how to resolve this issue? |
Hi @siriwatknp & @brijeshb42 . In hopes to fix the failing |
Thanks for submitting the PR. Even though this is a nice improvement but it comes with a cost for traversing the breakpoints especially in the This won't matter much with Pigment CSS integration but I'd hold this until v7 because ultra-wide customization is not a major use cases. |
@siriwatknp Thank you for your feedback and considering the PR! I'm happy to keep this PR on hold until v7 and would be more than willing to help with any necessary adjustments or updates when you're ready to revisit this feature. Feel free to ping me whenever the time comes! |
Added an ultra-wide breakpoint to be used within the Material-UI . The
uw
(ultra-wide) breakpoint is set to 2560px.The intent behind this new breakpoint is to enable the
<Grid />
component to be more responsive on ultra-wide monitors. This provides a distinct layout experience for users with ultra-wide screens, different from thexl
breakpoint.The
uw
naming was chosen overxxl
to maintain consistency with the two-letter format used for other breakpoints and to clearly distinguish it from thexl
breakpoint.