[website] Add Toolpad to main landing page #42939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-42939--material-ui.netlify.app/ Bundle size report |
Janpot
reviewed
Jul 15, 2024
| sx={tabsCustomStyles} | ||
| > | ||
| <Tab label="Serverless functions" {...a11yProps(0)} /> | ||
| <Tab label="yaml files" {...a11yProps(1)} /> |
There was a problem hiding this comment.
Suggested change
| <Tab label="yaml files" {...a11yProps(1)} /> | |
| <Tab label="Local first" {...a11yProps(1)} /> |
Janpot
reviewed
Jul 15, 2024
| > | ||
| <Tab label="Serverless functions" {...a11yProps(0)} /> | ||
| <Tab label="yaml files" {...a11yProps(1)} /> | ||
| <Tab label="React components" {...a11yProps(2)} /> |
There was a problem hiding this comment.
Suggested change
| <Tab label="React components" {...a11yProps(2)} /> | |
| <Tab label="Customize" {...a11yProps(2)} /> |
These are just suggestions. I'd also consider reordering
- Local first
- Serverless functions
- Customize
Janpot
reviewed
Jul 15, 2024
There was a problem hiding this comment.
I feel like it would make more sense to add the magnifier on the hierarchy explorer
Janpot
approved these changes
Jul 18, 2024
|
Should we call it Toolpad Studio instead of just Toolpad here? 
|
bharatkashyap
commented
Jul 19, 2024
Yes, lets replace it to Toolpad Studio. |
|
I made the change. Let's merge? |
Some tests seem to be stuck for me in the "Expected" state - I can push an empty commit to make CI re-run |
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Signed-off-by: Bharat Kashyap <[email protected]> Co-authored-by: MUI bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview