-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Add Toolpad to main landing page #42939
[website] Add Toolpad to main landing page #42939
Conversation
Netlify deploy previewhttps://deploy-preview-42939--material-ui.netlify.app/ Bundle size report |
sx={tabsCustomStyles} | ||
> | ||
<Tab label="Serverless functions" {...a11yProps(0)} /> | ||
<Tab label="yaml files" {...a11yProps(1)} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Tab label="yaml files" {...a11yProps(1)} /> | |
<Tab label="Local first" {...a11yProps(1)} /> |
> | ||
<Tab label="Serverless functions" {...a11yProps(0)} /> | ||
<Tab label="yaml files" {...a11yProps(1)} /> | ||
<Tab label="React components" {...a11yProps(2)} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Tab label="React components" {...a11yProps(2)} /> | |
<Tab label="Customize" {...a11yProps(2)} /> |
These are just suggestions. I'd also consider reordering
- Local first
- Serverless functions
- Customize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it would make more sense to add the magnifier on the hierarchy explorer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tweaked the wording a little bit more, looks good to me for the rest
Yes, lets replace it to Toolpad Studio. |
I made the change. Let's merge? |
Some tests seem to be stuck for me in the "Expected" state - I can push an empty commit to make CI re-run |
Signed-off-by: Bharat Kashyap <[email protected]> Co-authored-by: MUI bot <[email protected]>
preview