Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebDAV request method support #9459

Closed
1 task done
hungtcs opened this issue Apr 13, 2022 · 3 comments · May be fixed by #13278
Closed
1 task done

WebDAV request method support #9459

hungtcs opened this issue Apr 13, 2022 · 3 comments · May be fixed by #13278
Labels
needs triage This issue has not been looked into type: enhancement 🐺

Comments

@hungtcs
Copy link

hungtcs commented Apr 13, 2022

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

No issues yet.

Describe the solution you'd like

Add PROPFIND, PROPPATCH, MKCOL, COPY, MOVE, LOCK, UNLOCK request method support.

Teachability, documentation, adoption, migration strategy

express already supports these methods.

What is the motivation / use case for changing the behavior?

If i want to serve webdav, then we must return to the original express.
It would be great if I could use the decorator directly.
@hungtcs hungtcs added needs triage This issue has not been looked into type: enhancement 🐺 labels Apr 13, 2022
@hungtcs
Copy link
Author

hungtcs commented Apr 14, 2022

It looks like it works out of the box for express, just update the following files and add method declarations.

  1. packages/common/decorators/http/request-mapping.decorator.ts
  2. packages/common/enums/request-method.enum.ts
  3. packages/common/interfaces/http/http-server.interface.ts
  4. packages/core/adapters/http-adapter.ts
  5. packages/core/helpers/router-method-factory.ts

But fastify looks doesn't ready fastify/fastify#9

The other things is to completion http-status.enum.ts, add webdav status codes like 207 Multi-Status

@hungtcs hungtcs mentioned this issue Apr 14, 2022
Closed
12 tasks
@hungtcs
Copy link
Author

hungtcs commented Apr 14, 2022 •
edited

Does the community have any intentions in this regard? I submitted the small patch that I am currently using.

I have tried to use library to implement this function, but there is no way to handle interceptors, pipes, guards and other functions well.

There also a new Draft PR for fastify/fastify#3836

@kamilmysliwiec
Copy link
Member

Lets track this here #9465

@ArielSafar ArielSafar mentioned this issue Dec 15, 2023
Closed
12 tasks
@johaven johaven mentioned this issue Feb 5, 2024
Closed
12 tasks
@johaven johaven mentioned this issue Feb 29, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage This issue has not been looked into type: enhancement 🐺
Projects
None yet
Milestone
No milestone
2 participants
@hungtcs @kamilmysliwiec