Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to enable lock for order placement #7325

Open
AndreiMaz opened this issue Aug 29, 2024 · 0 comments
Open

Allow to enable lock for order placement #7325

AndreiMaz opened this issue Aug 29, 2024 · 0 comments

Comments

@AndreiMaz
Copy link
Member

AndreiMaz commented Aug 29, 2024

In some cases if could be helpful to allow a store owner to enable a lock when placing an order ("performwithlock").

For example. by executing a single packet attack, wherein multiple purchase requests are sent simultaneously the last bytes of said requests are held back and sent with a single packet. The server then processes the requests in parallel and a race condition occurs. Contact Andrei to get a detailed list of steps to reproduce the issue.

Let's allo to enable it. But with some conditions such as:

  1. Only for the same customer
    or
  2. For orders that redeem the same gift cards (in order to avoid duplicated redeems)

But allow a store owner to disable it because in some cases it could lead to deadlocks. And this lock (setting) will be disabled by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants