Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce label to trigger load tests for a Pull Request #33979

Closed
mowies opened this issue Jul 9, 2024 · 6 comments
Closed

Introduce label to trigger load tests for a Pull Request #33979

mowies opened this issue Jul 9, 2024 · 6 comments
Labels
ci-cd CI, CD, testing, build issues testbed

Comments

@mowies
Copy link
Contributor

mowies commented Jul 9, 2024 •
edited
Loading

Describe the issue you're reporting

As discussed in this PR, we could introduce a label called "Run Load Tests" (similar to the "Run Windows" label) that triggers the load tests for a pull request.

This would make development and maintenance of the load tests much easier, since they only run on main right now, and also only on self-hosted runners.
Right now, the load tests are fairly hard to maintain, since they are not fully reproducible for contributors, without access to the same self-hosted runners and the main branch limitation which doesn't run on PRs. Especially so, since the tests take hardware consumption into account as well, which differs between self-hosted and github-hosted runners (I assume).
@mowies mowies added the needs triage New item requiring triage label Jul 9, 2024
@mowies
Copy link
Contributor Author

mowies commented Jul 9, 2024

/label ci-cd

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Pinging code owners:

  • testbed: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mowies
Copy link
Contributor Author

mowies commented Jul 9, 2024

I'd be up for working on this

@crobert-1 crobert-1 added the ci-cd CI, CD, testing, build issues label Jul 9, 2024
@crobert-1
Copy link
Member

Sounds good to me, removing needs triage. You're welcome to work on this @mowies!

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jul 9, 2024
@mowies mowies mentioned this issue Jul 10, 2024
Closed
@mowies
Copy link
Contributor Author

mowies commented Jul 10, 2024

@crobert-1 @mx-psi PR is ready for review :)

@mowies
Copy link
Contributor Author

mowies commented Jul 15, 2024

closing this since it's not feasible. more details in the attached PR

@mowies mowies closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2024
@github-actions github-actions bot mentioned this issue Jul 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-cd CI, CD, testing, build issues testbed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] execute load tests based on label dynatrace-oss-contrib/opentelemetry-collector-contrib
2 participants
@mowies @crobert-1