Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Optimize Dataset class for NCF #1139

Open
miguelgfierro opened this issue Jul 7, 2020 · 0 comments
Open

[FEATURE] Optimize Dataset class for NCF #1139

miguelgfierro opened this issue Jul 7, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@miguelgfierro
Copy link
Collaborator

Description

The class https://github.com/microsoft/recommenders/blob/master/reco_utils/recommender/ncf/dataset.py consumes a lot of memory. With movielens 20M, there is an OOM when computing data = NCFDataset(train=train, test=test, seed=SEED) on a Standard NC6 (6 vcpus, 56 GiB memory)

@loomlike not sure whether the changes you suggested would help on this

Expected behavior with the suggested feature

Other Comments
@miguelgfierro miguelgfierro added the enhancement New feature or request label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miguelgfierro