Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF-3342] Factor router[_data] out of BaseState #3681

Open
benedikt-bartscher opened this issue Jul 17, 2024 · 0 comments
Open

[REF-3342] Factor router[_data] out of BaseState #3681

benedikt-bartscher opened this issue Jul 17, 2024 · 0 comments
Labels
enhancement Anything you want improved feature request A feature you wanted added to reflex linear Created by Linear-GitHub Sync

Comments

@benedikt-bartscher
Copy link
Contributor

benedikt-bartscher commented Jul 17, 2024 •
edited

During some testing for #2771 @abulvenz and I discovered that it's pretty annoying to have router and router_data in BaseState. Router stuff does not really make sense in a shared/global State context. Hence, a good implementation of shared/global State would require us to factor out the router vars from BaseState to State/RouterState

REF-3342
@Lendemor Lendemor added enhancement Anything you want improved feature request A feature you wanted added to reflex linear Created by Linear-GitHub Sync and removed custom component request labels Jul 19, 2024
@Lendemor Lendemor changed the title Factor router[_data] out of BaseState [REF-3342] Factor router[_data] out of BaseState Jul 19, 2024
This was referenced Aug 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Anything you want improved feature request A feature you wanted added to reflex linear Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lendemor @benedikt-bartscher