Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifying frontend about backend error looks better #3491

Merged
merged 9 commits into from
Jul 23, 2024

Conversation

Lendemor
Copy link
Collaborator

Use toast as the default for notifying about backend errors.

Can set debug=True in the config or the env var REFLEX_DEBUG=True to have a more helpful message in the frontend.

Will fallback to the old window_alert if the toast provider has been removed.

@Lendemor Lendemor marked this pull request as draft June 14, 2024 00:10
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like the direction here. will need a rebase after #3476 since the exception handling code has moved

@benedikt-bartscher
Copy link
Contributor

Just a heads up, the new exception handling was merged in #3572 and #3637

@Lendemor Lendemor marked this pull request as ready for review July 17, 2024 12:48
@Lendemor
Copy link
Collaborator Author

Rebased to use the new exception handling.

Need reflex-dev/reflex-web#813 to pass CI

reflex/app.py Outdated Show resolved Hide resolved
reflex/app.py Show resolved Hide resolved
reflex/config.py Outdated Show resolved Hide resolved
reflex/app.py Outdated Show resolved Hide resolved
@picklelo picklelo merged commit b9927b6 into main Jul 23, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants