Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell Checking #258

Closed
Lamer217 opened this issue May 25, 2024 · 6 comments
Closed

Spell Checking #258

Lamer217 opened this issue May 25, 2024 · 6 comments

Comments

@Lamer217
Copy link

I've noticed that the Reor app currently does not have any spell-checking functionality. I'm wondering if this is a feature that has not yet been implemented, or if it is an intentional design choice?

Rationale:
As the app is focused on taking notes, I believe that having spell-checking would be a valuable feature. Ensuring correct spelling is important for note-taking, as it enhances the readability and professionalism of the notes.

Proposal:
I propose adding spell-checking functionality to the Reor app. This could be implemented as an optional feature that users can enable or disable based on their preference.

Thank you for considering this feature request.

@samlhuillier
Copy link
Collaborator

Thank you for mentioning this!

Yes this is something that we definitely can add. It was removed a couple of weeks back so that the welcome message (in English) would not just show a bunch of spelling errors to users with non-English machines.

It'll need to be added in settings as a toggle which saves the spellcheck preference in settings. Would you be interested in contributing to this feature? I'd love to see a contribution from you and I can help out where needed :)

@sebastian-philipp
Copy link

Maybe relates to #237 ?

@weilirs
Copy link
Collaborator

weilirs commented Jun 1, 2024

I'll see if I can help with this, would love to contribute!

@samlhuillier
Copy link
Collaborator

Just a little pointer @weilirs you'll see spellcheck was disabled in use-file-by-filepath.ts:

spellcheck: "false"

@weilirs
Copy link
Collaborator

weilirs commented Jun 2, 2024

For this feature, is it better to have a "General" page in the settings to manage preferences like this? I don't know if it is crucial enough to have a page itself like "Chunk Size".

Also, this preference needs to be added to electron store?

@samlhuillier
Copy link
Collaborator

Yes I completely agree with you although I'd suggest a different categorisation: chunk size should really be part of RAG settings and spellcheck could be under either "Editor Settings" or "General" - your call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants