Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't show formula and picture correctly #286

Open
ZeroCore-Zero opened this issue Jun 19, 2024 · 11 comments
Open

Can't show formula and picture correctly #286

ZeroCore-Zero opened this issue Jun 19, 2024 · 11 comments
Labels
enhancement New feature or request

Comments

@ZeroCore-Zero
Copy link

Describe the bug
I copied my existing notes to the vault dictionary, whick contains some formulas and pictures, but when i open it in reor, it can't show correctly.
Source file is here: note.zip

Expected behavior
Formulas and pictures can be showed correctly

Screenshots

This is my note.
image
This is my source code in showed in VSCode.
image
This is the expected view with VSCode.
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Version 0.2.10

Additional context
btw, is there any way to check application version in it? I can't find it. QAQ

@weilirs weilirs added the enhancement New feature or request label Aug 1, 2024
@tusharkaran
Copy link

Working on it

@tusharkaran
Copy link

tusharkaran commented Aug 4, 2024

'@tiptap/react' this extenstion which is currently used for editor , does not support formulas and pictures , can I use some other extension ?

@weilirs
Copy link
Collaborator

weilirs commented Aug 4, 2024

'@tiptap/react' this extenstion which is currently used for editor , does not support formulas and pictures , can I use some other extension ?

Maybe you can try this one? https://tiptap.dev/docs/editor/extensions/nodes/image

@tusharkaran
Copy link

tusharkaran commented Aug 4, 2024

Ohk , thank you @weilirs .
will check this one

@samlhuillier
Copy link
Collaborator

samlhuillier commented Aug 4, 2024

Or perhaps this extension is the one we're after: https://tiptap.dev/docs/editor/extensions/functionality/mathematics

Although it looks like it's paid. If you think this is what we're after, I'll look into sorting out a tiptap pro subscription @tusharkaran

@tusharkaran
Copy link

image

IS this good ?
But this is pro extension .
Apart from that this does not support image

@tusharkaran
Copy link

for images , https://tiptap.dev/docs/editor/extensions/nodes/image

This does not have drag and drop functionality . Although ordering of image can change by dragging.
It has a button which , on click it asks the URL of image , then it gets added , as shown in the extension .

@weilirs
Copy link
Collaborator

weilirs commented Aug 6, 2024

image

IS this good ? But this is pro extension . Apart from that this does not support image

I noticed that some formulas are not displaying correctly, but others are working fine. Can you fix the ones that are broken?
Regarding images, I came across this post: https://stackoverflow.com/questions/78147060/how-to-upload-inserted-images-with-image-extension-in-tiptap. Maybe you can give it a try.

@tusharkaran
Copy link

image
Mathematics formulas are working now .

Images I not sure , not getting idea from that regference as well .

@weilirs
Copy link
Collaborator

weilirs commented Aug 10, 2024

LGTM! You can make a PR for the formula itself. Don't worry about images for now.

@tusharkaran
Copy link

#342

Raised A PR for the Formula . Please Install the Dependencies , as those were PRO Extension . so they require credential.
Have mention the command and link of Extension in The PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants