Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework fs filter byte-ranges, fixes #867 #872

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

rework fs filter byte-ranges, fixes #867 #872

wants to merge 2 commits into from

Conversation

jxs
Copy link
Collaborator

@jxs jxs commented Jun 27, 2021

No description provided.

jxs
jxs commented Jun 27, 2021
View reviewed changes
src/filters/fs.rs Show resolved Hide resolved
@jxs jxs requested a review from seanmonstar June 27, 2021 15:04
@jxs jxs added the waiting-on-reviewer Awaiting review from the assignee but also interested parties. label Jun 29, 2021
joseluisq
joseluisq reviewed Jul 21, 2021
View reviewed changes
src/filters/fs.rs Outdated Show resolved Hide resolved
@jxs jxs force-pushed the master branch 2 times, most recently from 0431a2a to 052b8e8 Compare July 22, 2021 10:48
joseluisq added a commit to static-web-server/static-web-server that referenced this pull request Aug 9, 2021
@joseluisq
fix: return incorrect first bytes range when final bytes requested
2459ec4 
for example a request using 'Range: bytes=-10' header returns
incorrectly the first 10 bytes rather than the last 10 ones
according to https://datatracker.ietf.org/doc/html/rfc7233#section-2.1

note: this is borrowed from seanmonstar/warp#872
and adapted to this project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseluisq joseluisq joseluisq left review comments

@seanmonstar seanmonstar Awaiting requested review from seanmonstar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
waiting-on-reviewer Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jxs @joseluisq