[5.x] Adds character replacements to ensure valid file names on Windows #10423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10421
It's possible for assets to be uploaded with, what Windows considers, invalid characters in pathname.
See Windows naming convention documentation for reference
This becomes a problem when hosting a live/dev site on a Linux system and the developer machine is Windows.
The client is uploading lots of files containing these characters and this prevents a Windows developer from pulling the latest content onto a local machine:
(* this is a redo of #10422 to address ' resubmit this PR from a personal GitHub account with maintainer permissions enabled')