Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tooling: Fix git push commands in publish action #28505

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jul 10, 2024

Closes #

What I did

Fixing the force push step in the publish job.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This pull request updates the git push commands in the publish.yml workflow file, focusing on the force push step in the publish job.

  • Modified .github/workflows/publish.yml to adjust the git push commands
  • Updated force push step in the publish job for improved reliability
  • Changes likely affect the workflow's behavior when pushing to release branches
  • Potential impact on the automated release process and version management

@valentinpalkovic valentinpalkovic changed the title Build: Update git push commands in publish.yml [WIP] Build: Update git push commands in publish.yml Jul 10, 2024
@valentinpalkovic valentinpalkovic added ci: do not merge build Internal-facing build tooling & test updates labels Jul 10, 2024
@valentinpalkovic
Copy link
Contributor Author

cc @JReinhold

Copy link

nx-cloud bot commented Jul 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 80b3dce. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JReinhold JReinhold marked this pull request as ready for review August 19, 2024 11:54
@JReinhold JReinhold changed the title [WIP] Build: Update git push commands in publish.yml Release tooling: Fix git push commands in publish action Aug 19, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@JReinhold JReinhold added ci:docs Run the CI jobs for documentation checks only. and removed ci: do not merge labels Aug 19, 2024
@JReinhold JReinhold merged commit e0daec5 into next Aug 19, 2024
4 checks passed
@JReinhold JReinhold deleted the valentin/fix-force-push-step-in-publish-step branch August 19, 2024 11:56
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:docs Run the CI jobs for documentation checks only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants