Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls: Fix color control automatically pops up #28561

Open
wants to merge 7 commits into
base: next
Choose a base branch
from

Conversation

nikhilbhatt
Copy link

@nikhilbhatt nikhilbhatt commented Jul 12, 2024

Closes #28511

What I did

Disabled the color pop up to open automatically, it was set to true earlier.
code/addons/controls/template/stories/basics.stories.ts

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.4 MB 76.4 MB 0 B 0.99 0%
initSize 169 MB 169 MB 0 B 1.02 0%
diffSize 92.8 MB 92.8 MB 0 B 1.07 0%
buildSize 7.46 MB 7.46 MB 0 B 1.45 0%
buildSbAddonsSize 1.62 MB 1.62 MB 0 B 1.14 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.3 MB 2.3 MB 0 B - 0%
buildSbPreviewSize 352 kB 352 kB 0 B 1.36 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.46 MB 4.46 MB 0 B 1.23 0%
buildPreviewSize 3 MB 3 MB 0 B 1.53 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 6.7s 19.9s 13.2s 0.42 66.3%
generateTime 19s 22.4s 3.4s 0.45 15.5%
initTime 15.7s 19.5s 3.8s 1.69 🔺19.5%
buildTime 11.9s 11.8s -90ms -0.82 -0.8%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 7.8s 7.8s -17ms 0.54 -0.2%
devManagerResponsive 4.7s 5.1s 419ms 0.58 8.2%
devManagerHeaderVisible 735ms 800ms 65ms -0.13 8.1%
devManagerIndexVisible 767ms 831ms 64ms -0.23 7.7%
devStoryVisibleUncached 1.3s 1.6s 248ms 1.17 15.5%
devStoryVisible 766ms 832ms 66ms -0.24 7.9%
devAutodocsVisible 732ms 691ms -41ms -0.56 -5.9%
devMDXVisible 630ms 748ms 118ms 0.35 15.8%
buildManagerHeaderVisible 678ms 634ms -44ms -1.6 🔰-6.9%
buildManagerIndexVisible 683ms 640ms -43ms -1.53 🔰-6.7%
buildStoryVisible 717ms 688ms -29ms -1.5 -4.2%
buildAutodocsVisible 690ms 597ms -93ms -1.84 🔰-15.6%
buildMDXVisible 631ms 578ms -53ms -1.54 🔰-9.2%

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Disabled automatic pop-up of color control (startOpen: false) in code/addons/controls/template/stories/basics.stories.ts.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@nikhilbhatt nikhilbhatt changed the title Fix color control automatically pops up Bug: Fix color control automatically pops up Jul 12, 2024
@shilman shilman changed the title Bug: Fix color control automatically pops up Controls: Fix color control automatically pops up Jul 15, 2024
@shilman shilman self-assigned this Jul 15, 2024
@nikhilbhatt
Copy link
Author

Do I need to do any additional work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Color control automatically pops up, without triggering the control itself
2 participants