Telemetry: CSF feature usage #28622
Merged
Telemetry: CSF feature usage #28622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 631bafd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
4 tasks
tmeasday
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
PR Summary
- Updated
code/core/package.jsonto use@storybook/[email protected] - Enhanced
StoryIndexGenerator.tsto track CSF features in telemetry - Added
summarizeStats.tsand corresponding tests for aggregating CSF stats - Modified
doTelemetry.tsto capture detailed CSF feature usage - Introduced mock stories in
Features.stories.jsxfor telemetry testing
13 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| Object.entries(stat).forEach(([key, value]) => { | ||
| const statsKey = key as keyof IndexInputStats; | ||
| if (!acc[statsKey]) acc[statsKey] = 0; | ||
| acc[statsKey] += value ? 1 : 0; |
There was a problem hiding this comment.
Logic: The increment logic acc[statsKey] += value ? 1 : 0 only increments by 1 if value is truthy. Ensure this is the intended behavior.
This was referenced Jul 19, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
Add the ability to track CSF language features in telemetry without touching the index. This PR tracks stories that use custom
renderfunction and CSF1/2storyFn-style stories. Will telescope PRs to add new CSF constructs includingbeforeEach,mount,moduleMocking, etc.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Run a sandbox with
STORYBOOK_TELEMETRY_DEBUG=1and observe the payload with the number ofrender/storyFncounts.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>