Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Spanish translation for docs/es/docs/how-to/graphql.md #11697

Merged
merged 6 commits into from
Jul 14, 2024

Conversation

camigomezdev
Copy link
Contributor

No description provided.

@tiangolo
Copy link
Member

tiangolo commented Jun 7, 2024

📝 Docs preview for commit 50224d0 at: https://0a3f26fd.fastapitiangolo.pages.dev

@ajpinedam
Copy link
Contributor

@tiangolo This PR came from the GraphQL presentation at PyCon Colombia. It's nice to see someone step up and complete this translation, which will help others.

Thank you @camigomezdev

Copy link
Member

@alejsdev alejsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En general LGTM, faltan un par de tildes y corregir un typo. 😸

docs/es/docs/how-to/graphql.md Outdated Show resolved Hide resolved
docs/es/docs/how-to/graphql.md Outdated Show resolved Hide resolved
docs/es/docs/how-to/graphql.md Outdated Show resolved Hide resolved
docs/es/docs/how-to/graphql.md Outdated Show resolved Hide resolved
docs/es/docs/how-to/graphql.md Outdated Show resolved Hide resolved
docs/es/docs/how-to/graphql.md Outdated Show resolved Hide resolved
docs/es/docs/how-to/graphql.md Outdated Show resolved Hide resolved
docs/es/docs/how-to/graphql.md Outdated Show resolved Hide resolved
@alejsdev alejsdev added lang-all Translations lang-es Spanish translations awaiting-review labels Jun 9, 2024
@alejsdev alejsdev changed the title 🌐 Add Spanish translation for docs/es/docs/how-to/graphql.md 🌐 Add Spanish translation for docs/es/docs/how-to/graphql.md Jun 9, 2024
@tiangolo
Copy link
Member

tiangolo commented Jun 9, 2024

📝 Docs preview for commit 74aa87a at: https://c58184f8.fastapitiangolo.pages.dev

Copy link
Member

@alejsdev alejsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola! Es un detalle menor y creo que lo pasé por alto en el review anterior, pero cuando el "si" es condicional no lleva tilde.

Además, normalmente en la documentación se ha dejado la palabra "library" en inglés, ya que la traducción "librería" es incorrecta. No sé si se debería ajustar eso en este caso, ya que la palabra se usa varias veces. Thoughts? @tiangolo 🤔

docs/es/docs/how-to/graphql.md Outdated Show resolved Hide resolved
docs/es/docs/how-to/graphql.md Outdated Show resolved Hide resolved
docs/es/docs/how-to/graphql.md Outdated Show resolved Hide resolved
docs/es/docs/how-to/graphql.md Outdated Show resolved Hide resolved
docs/es/docs/how-to/graphql.md Outdated Show resolved Hide resolved
@tiangolo
Copy link
Member

Además, normalmente en la documentación se ha dejado la palabra "library" en inglés, ya que la traducción "librería" es incorrecta. No sé si se debería ajustar eso en este caso, ya que la palabra se usa varias veces. Thoughts? @tiangolo 🤔

Sip, de acuerdo con @alejsdev, tal cual todo 💯 Gracias! 🤓

@camigomezdev camigomezdev force-pushed the master branch 2 times, most recently from e486da5 to 73c5d12 Compare June 14, 2024 21:22
@camigomezdev
Copy link
Contributor Author

Quedo atenta si hay mas comentarios :)

@tiangolo
Copy link
Member

📝 Docs preview for commit 246b6d0 at: https://a1c69998.fastapitiangolo.pages.dev

@camigomezdev
Copy link
Contributor Author

@alejsdev Estoy pendiente si hay alguna actualización adicional para hacer :)

@tiangolo
Copy link
Member

📝 Docs preview for commit 65693b5 at: https://cb0d308b.fastapitiangolo.pages.dev

@alejsdev alejsdev merged commit ebc6a06 into fastapi:master Jul 14, 2024
44 checks passed
@alejsdev
Copy link
Member

Hola! 🤓
Subí unos pequeños ajustes que había pasado por alto (65693b5) 😅
Gracias a los dos por la ayuda @camigomezdev @ajpinedam 😸 ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-es Spanish translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants