-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Spanish translation for docs/es/docs/how-to/graphql.md
#11697
Conversation
📝 Docs preview for commit 50224d0 at: https://0a3f26fd.fastapitiangolo.pages.dev |
@tiangolo This PR came from the GraphQL presentation at PyCon Colombia. It's nice to see someone step up and complete this translation, which will help others. Thank you @camigomezdev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
En general LGTM, faltan un par de tildes y corregir un typo. 😸
docs/es/docs/how-to/graphql.md
📝 Docs preview for commit 74aa87a at: https://c58184f8.fastapitiangolo.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hola! Es un detalle menor y creo que lo pasé por alto en el review anterior, pero cuando el "si" es condicional no lleva tilde.
Además, normalmente en la documentación se ha dejado la palabra "library" en inglés, ya que la traducción "librería" es incorrecta. No sé si se debería ajustar eso en este caso, ya que la palabra se usa varias veces. Thoughts? @tiangolo 🤔
e486da5
to
73c5d12
Compare
Quedo atenta si hay mas comentarios :) |
📝 Docs preview for commit 246b6d0 at: https://a1c69998.fastapitiangolo.pages.dev |
@alejsdev Estoy pendiente si hay alguna actualización adicional para hacer :) |
📝 Docs preview for commit 65693b5 at: https://cb0d308b.fastapitiangolo.pages.dev |
Hola! 🤓 |
No description provided.