Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Portuguese translation for docs/pt/docs/how-to/general.md #11825

Merged
merged 5 commits into from
Jul 12, 2024

Conversation

lucasbalieiro
Copy link
Contributor

Hello guys,

this is just the translation to PT of the doc in docs/pt/docs/how-to/general.md.

@lucasbalieiro lucasbalieiro changed the title Add pt translation for docs/pt/docs/how-to/general.md 🌐 Add pt translation for docs/pt/docs/how-to/general.md Jul 10, 2024
@tiangolo
Copy link
Member

📝 Docs preview for commit bf05b15 at: https://a97da75b.fastapitiangolo.pages.dev

Although I personally prefer a different translation (or no translation at all for this term), this aligns with the existing Portuguese translations in the project.
@lucasbalieiro lucasbalieiro changed the title 🌐 Add pt translation for docs/pt/docs/how-to/general.md 🌐 Add Portuguese translation for docs/pt/docs/how-to/general.md Jul 11, 2024
@tiangolo
Copy link
Member

📝 Docs preview for commit 91a0b99 at: https://fe16ccf4.fastapitiangolo.pages.dev

@alejsdev alejsdev changed the title 🌐 Add Portuguese translation for docs/pt/docs/how-to/general.md 🌐 Add Portuguese translation for docs/pt/docs/how-to/general.md Jul 11, 2024
@alejsdev alejsdev added docs Documentation about how to use FastAPI awaiting-review lang-all Translations lang-pt Portuguese translations and removed docs Documentation about how to use FastAPI labels Jul 11, 2024
Copy link
Contributor

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good enough to be merged to the main branch.

Thanks for your contribution.

Copy link
Contributor

@ceb10n ceb10n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translation 🚀

Just found some accents missing and some extra commas

docs/pt/docs/how-to/general.md Outdated Show resolved Hide resolved
docs/pt/docs/how-to/general.md Outdated Show resolved Hide resolved
docs/pt/docs/how-to/general.md Outdated Show resolved Hide resolved
docs/pt/docs/how-to/general.md Outdated Show resolved Hide resolved
docs/pt/docs/how-to/general.md Outdated Show resolved Hide resolved
@lucasbalieiro
Copy link
Contributor Author

Many thanks to @nazarepiedady and @ceb10n!

@ceb10n, I've implemented the corrections you suggested in this commit: commit link.

@tiangolo
Copy link
Member

📝 Docs preview for commit 81087d0 at: https://218acbed.fastapitiangolo.pages.dev

@tiangolo
Copy link
Member

📝 Docs preview for commit 53b21c8 at: https://b20e9ae1.fastapitiangolo.pages.dev

@alejsdev alejsdev merged commit c8414b9 into fastapi:master Jul 12, 2024
44 checks passed
@alejsdev
Copy link
Member

Thank you all for your help and contribution! ✨ @lucasbalieiro @ceb10n @nazarepiedady

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-1 lang-all Translations lang-pt Portuguese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants