Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Portuguese translation for docs/pt/docs/tutorial/dependencies/dependencies-with-yield.md #11848

Conversation

Joao-Pedro-P-Holanda
Copy link
Contributor

No description provided.

@tiangolo
Copy link
Member

📝 Docs preview for commit ac056ff at: https://c0763452.fastapitiangolo.pages.dev

@alejsdev alejsdev added lang-all Translations lang-pt Portuguese translations awaiting-review labels Jul 15, 2024
Copy link
Contributor

@lucasbalieiro lucasbalieiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice and well-crafted translation.

Good job, @Joao-Pedro-P-Holanda !

Just a few small things that I’ve noticed

Copy link
Contributor

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the little error mentioned by @lucasbalieiro, there is nothing to complain about, and this translation can be merged and then updated missing point.

@Joao-Pedro-P-Holanda
Copy link
Contributor Author

Before merging i would like to address the points marked by @lucasbalieiro

Copy link
Contributor

@ceb10n ceb10n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great translation @Joao-Pedro-P-Holanda 🚀🚀🚀

I only saw one minor typo in addition to the revisions already made.

Thank you!

@tiangolo
Copy link
Member

📝 Docs preview for commit 795e7a2 at: https://612eb8ab.fastapitiangolo.pages.dev

Copy link
Contributor

@lucasbalieiro lucasbalieiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!!

Copy link
Contributor

@ceb10n ceb10n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@alejsdev alejsdev merged commit a5fbbee into fastapi:master Jul 18, 2024
44 checks passed
@alejsdev
Copy link
Member

Cool! Thanks to all for the contribution and help 🚀 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-1 lang-all Translations lang-pt Portuguese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants