-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline code followed by emphasis consumes extra whitespace #957
Comments
Ah that's very useful thanks. It shouldn't be hard to fix, I'll have a look soon dev note: this is |
ok so actually this is not easy to fix without risking breaking some other stuff. However this is not an issue in the upcoming version of Franklin:
source of the problem + why it's hard to fixThe current version of Franklin (and all previous versions) wrap around
Now for reasons that are a bit annoying to get into, this injection adds spaces around itself. But this can cause issues with nesting with proper markdown, you might end up with:
but that won't work because
you found a corner case: code stuff gets handled specifically by Franklin, so gets replaced by the insert token, if immediately followed by We could add some more logic to fix this further but in the next version of Franklin the whole parsing is done by us (we don't use Base.Markdown anymore) and so this "intermediate markdown" stuff doesn't happen. Given that it'll be brought in fairly soon, I think it's reasonable to leave things as is. What to do with this problem and Franklin 0.10.xdouble the space between the inline code and the italic/bold, browsers won't render double whitespaces. |
Understood, and the double whitespace is an easy workaround. I agree that it's not worth changing if the markdown parser is going to be replaced. |
I'm observing a probably unintended behaviour that inline code followed by either italic or bold emphasis consumes one additional trailing space character:
I'm on
[713c75ef] Franklin v0.10.72
with Julia:Let me know if you can trivially reproduce it otherwise I'll send a more complete example.
The text was updated successfully, but these errors were encountered: