[cssom-view] Stop using "incumbent settings object"? #1725
Labels
Comments
18 tasks
|
I would be very surprised if implementations used incumbent here. It would mean that if you did <script>
const w = window.open();
w.moveTo(x, y);
</script>it would move the containing window (containing the script element), and not the opened window. So this is likely a spec bug. It would be great to have someone write tests though, especially to distinguish between current and relevant. |
emilio
pushed a commit
that referenced
this issue
Jul 29, 2021
Closes #1725 by removing the usage of incumbent settings object. I could find no evidence of such a check in the Blink, Gecko, or WebKit codebases. Indeed, such a check should not generally be necessary, as (unlike, e.g., window.close()) these methods are not accessible cross-origin. Also includes various changes for things that have updated in other specs: * Use "this" instead of "context object" * Use "string is" instead of "case-sensitive" * Use "start node" and "start offset" instead of referring to properties of Range (or now, AbstractRange) * Link to the correct "event loop" definition * Remove redundant anchor blocks, as these days most definitions are properly exported
mfreed7
pushed a commit
to mfreed7/csswg-drafts
that referenced
this issue
Aug 4, 2021
Closes w3c#1725 by removing the usage of incumbent settings object. I could find no evidence of such a check in the Blink, Gecko, or WebKit codebases. Indeed, such a check should not generally be necessary, as (unlike, e.g., window.close()) these methods are not accessible cross-origin. Also includes various changes for things that have updated in other specs: * Use "this" instead of "context object" * Use "string is" instead of "case-sensitive" * Use "start node" and "start offset" instead of referring to properties of Range (or now, AbstractRange) * Link to the correct "event loop" definition * Remove redundant anchor blocks, as these days most definitions are properly exported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
"Incumbent settings object" is utilized in several places in CSSOM View, although there's a warning in the HTML Standard:
The text was updated successfully, but these errors were encountered: