It may make sense to wait until T367240 is complete before starting this, even though this is the one that will be blocking CTT visual diff testing

Gonna raise the priority on this one to reflect the above - @ovasileva @Jdlrobson feel free to override me while I'm out

Can confirm I just got in - thank you so much!!

We should also try to answer T371919 in this meeting/consider merging the two tickets

Ideally this question would be discussed in T371921/these can probably be merged

giving this a zero since it's scheduling a meeting

@Jdlrobson @ovasileva we had some questions about this one - for the sake of prioritization, we're not clear on where these are appearing on wikis/what approach should be taken here. Could we get some examples of this in the wild/a sense of how common this is irl?

We talked about this in estimation and realized that, since we need to server side render some of this and currently the logic for determining which headers are collapsible lives in JS, that we need to pull that logic out of the JS and move it to the backend. Once we've got the collapsible header logic in PHP, we can hold space for the icons using CSS or render them on the backend

Work is mainly to review patch and test to ensure no visual changes (in both day and night mode)

(drop the priority that is)

@ovasileva question on the priority of this given scope - would love to get your input on whether we should drop it

Signing this one off - posted in our team channel about some of our thoughts regarding this, and we look forward to any further discussion around monitoring best practices!

@ovasileva @sgrabarczuk wanted to confirm that in addition to the list in the description, we also have kswiki and ttwiki in the deploy patch

Example of a less file: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikimediaMessages/+/e2f5e73126f7405415061416d3323e17639ddfea/modules/ext.wikimediamessages.styles/theme-night.less

@DLynch in our team meeting just now it was suggested that based on the conversation above this ticket should live with editing - I was told DiscussionTools would be a better tag than the general editing team. @JScherer-WMF let me know if I did something wrong here?

@Jdlrobson @ovasileva not sure why Olga is assigned to this - we estimated, but wanted to make sure there are not any remaining product/design questions before this is picked up

Blocked on T371020 - in grooming we agreed it would be good to get the acceptance criteria/scope of this nailed down a bit more

Moving back to needs analysis to discuss icon nomenclature (wrt caching implications) - @bwang to lead convo as he has the most context

@SToyofuku-WMF to add example of this in prod

Let us know if you need any help on this!

Let us know if you want to move this to a future sprint/what the plan should be here!

Let us know if you need any guidance on this!

@Edtadros looks like neither font size nor night mode have any pages disabled on beta :/

Moving to doing but leaving unassigned since we're all working on this right now - unless you want to put your face on it @KSarabia-WMF?

@GMikesell-WMF does https://fr.wikipedia.org/wiki/Torchage_du_gaz_naturel#Aspects_techniques work?

Ah they updated the image :/

Thank you all for your help!

Slight update to instructions in repo - everything else looks great ☺️

Plan is to backport asap (but not UBN), ideally Monday

Makes sense, but let's consider that like you said if we were to provide this option a lot of users would end up "hitting themselves in the head" as you put it. While I hear what you're saying and don't disagree with the stated goal, it sounds like we're in agreement that the current approach in the patch would lead to a number of people other than you getting a broken experience and potentially being confused. Indeed, we added the logic that exists today in response to a number of people requesting it, given the confusing interaction between the gadget and our native implementation

Hi there! Apologies for blocking your patch, but I did a great deal of research into the existing gadget when writing the code that is currently present and there are a few considerations here that are not immediately obvious:

1. because of the way that the gadget uses both user options and local storage, if the gadget is disabled without disabling the toggle it results in the two falling out of sync
2. I tested the proposed patch locally, and it did not correctly disable the gadget, resulting in an immediate double invert

I believe I added halfway decent beta QA steps

Gotcha, thank you!

@Jdlrobson is it just me or do the repro steps no longer work?

Putting down for now to wrap up higher priority night mode tickets first

Raising the priority to reflect the above

@GMikesell-WMF heads up, we're declining this since the deploy was a significant amount of time ago and we have a number of more recent deploy verification tickets in QA

^ I believe that's expected as it was merged yesterday and testwiki isn't deployed until Tuesday

Blocked pending a discussion in team sync tomorrow

Moving to code review for the formulas - pending a response from @JScherer-WMF on whether we need to do anything about the text

@JScherer-WMF what do you think of AC2? From what I can tell it passes color contrast, but I agree it's a bit hard to read

Not @Jdrewniak but, I believe as it's currently set up people who have night mode turned on (beta feature, etc) will receive the banner, but currently the wording is identical to the copy for day mode

Sounds good! Currently struggling to even get the extension set up locally, so we'll cross that bridge when we get to it haha

@Jdlrobson @Jdrewniak assuming it's fine for me to pick this up

Moving to ready for development as I believe it's important for this to be done this sprint, but feel free to move it if I'm disrupting anything @ovasileva @Jdlrobson !!

Value continues to trend down, gonna mark this as resolved

Steph to sign off

Also noting the most effective way I've found to batch replace seems to be this regex: var\(\s*--(\S+)\s*\) and replacing with @$1, which I am now spot checking to make sure they exist

@Jdrewniak as I'm doing this, I'm seeing that in addition to some css variables not having fallbacks, the fallbacks also appear to be for day mode even when we're in night mode:

@Edtadros lmk if you need more info on this ticket I realize it's fairly lean! Should be similar to T366334 with a slightly updated list of pages and now also on pl nl and es wikipedias