-
-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is the docker image still supported? #63
Comments
We did not want to maintain the Dockerfile in this repository (see #50), so it got moved into webhook-contrib repository. |
@adnanh thx for the clarification. than the first question still stays, according to https://hub.docker.com/r/adnanh/webhook/builds/ there hasn't been a successful build since beginning of November. As far as I see it, this is also the docker image referenced from the https://github.com/adnanh/webhook-contrib/issues repository. Is there maybe another image which I didn't find? and secondly - maybe the link to the discussion could be mentioned in the readme, as it was suggested? thx |
The Dockerfile in webhook-contrib repository should serve as a guide on how to make your own image. I am going to include a link to this discussion for the others interested in running webhook inside a container in the README.md in this repository. I will also remove docker image from docker hub, as it's not maintained anymore, and it's now misleading users. |
this clarifies everything, thx |
Now there is a good dockerized version of webhook at https://github.com/almir/docker-webhook |
Pretty cool utility. I couldn't get this to run properly in a docker container. Webhooks itself runs fine, but can't get the build script on the host computer to run properly due to paths, access to resources that aren't mapped to the container, etc. |
Same problem as @lookingcloudy reports. Just asked @almir how to control docker containers on the host from a dockerised |
If somebody is searching for a working image. I made an image on dockerhub based on almir/docker-webhook and the official docker image, to control docker containers of the host from inside this container. |
I can add it to README.md if you want? |
Yes, would be nice. Probably this will help somebody someday. |
@LWlook could you potentially give an example of how controlling the other containers would work? That's exactly what I'm looking for, but I can't figure it out. |
@regisin I just deployed the container like in the "Running the container"-Section described. Then i made an script with for example "docker compose up -d". But you can call in the script every docker command and it will be called on the host. |
I must be missing something. When the hook is triggered and it runs Could you provide the functioning |
You have to make the docker-compose.yaml accessible in the container (eg mount a volume with the docker-compose file). If the docker-compose is not in the working dir, than you have to cd to that dir, or specify the location (docker compose -f /path/in/container/to/dockerfile.yaml up -d) Check if the neccessary files are accessible IN the container and on the correct location (eg the scripts are in /opt/scripts). |
It's already 2024. Shouldn't docker be officially supported? |
Hi, I've found https://hub.docker.com/r/adnanh/webhook/ and wanted to use it, to build my own container which would respond to web hooks. However I saw that in beginning of November after at first adding a description about the image, it got removed again few days later.
May I ask why the docker documentation got removed again?
The text was updated successfully, but these errors were encountered: