-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make channel ID and name configurable in DefaultMediaNotificationProvider #104
Comments
The naming comes from our convention to have an interface defined from a component like You can override the drawables resource names for existing buttons as you already mentioned. The API allows you to do your own buttons by overriding Lastly, we should make the channel ID and the channel name configurable for the |
@marcbaechinger Thanks for the reply and tip!
Sorry for not being clear, I actually meant the small notification icon ( |
Add a Builder to constructor DefaultMediaNotificationProvider. The Builder can also set the provider's: - notification ID - notification channel ID - notification channel name The change adds an API for apps to set the small icon in notifications. #minor-release Issue: #104 PiperOrigin-RevId: 462111536
We changed DefaultMediaNotificationProvider so that
The commit will appear here once it's pushed to the main branch. I'll close this issue but feel free to re-open if something did not work as expected. |
Add a Builder to constructor DefaultMediaNotificationProvider. The Builder can also set the provider's: - notification ID - notification channel ID - notification channel name The change adds an API for apps to set the small icon in notifications. #minor-release Issue: #104 PiperOrigin-RevId: 462111536 (cherry picked from commit 436ff6d)
Use case description
After integrating your
DefaultMediaNotificationProvider
with theMediaSessionService
, I found that there are a few points worth to be discussed, but before jumping into them, I'd like to make sure that I understand the purpose of this class correctly.Our use case is quite straightforward, displaying media notification for audio playback with custom actions, and the notification building/ bitmap handling in
DefaultMediaNotificationProvider
is exactly what I need, so I chose to extend this class, provide ownBitmapLoader
implementation, and override the member functions to achieve the custom actions rather than providing full-blown implementation from scratch.Everything is working fine, but here are a few things that our team and I think would be nice to improve:
Default
naming prefix of the class made me think that we should provide our own implementation originally, but turns out it's quite flexible and we can just extend from it. Maybe a better naming is possible here?Please let us know your thought about those points, we'll be glad if any of them makes sense to you! Thanks as always.
The text was updated successfully, but these errors were encountered: