-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IllegalStateException in MediaControllerImplBase.maskPositionInfo #122
Comments
You are running into an assertion that checks that no ads are playing. I'm not quite sure why this assertion is there tbh. Because a few lines further down |
I can repro this when I seek with a I think this assertion can be safely removed to avoid this crash. It's unclear to me what it should prevent. |
Thanks @marcbaechinger for your investigation. Do you want me to create a PR? |
@ziem No need for that, a fix is already being submitted in our internal codebase and should appear here soon. |
Okay, thanks 🙂 |
The assertion asserts against a `Period` and an `AdPlaybackState` which actually asserts against a resolved ad which is what `ExoPlayerImplInternal` does later and what gives us a `SEEK_ADJUSTMENT`. However, this assertion is not required at the moment of masking, because we are sure that the resolved seek results in a content period and never an ad period. #minor-release Issue: #122 PiperOrigin-RevId: 471827072
The assertion asserts against a `Period` and an `AdPlaybackState` which actually asserts against a resolved ad which is what `ExoPlayerImplInternal` does later and what gives us a `SEEK_ADJUSTMENT`. However, this assertion is not required at the moment of masking, because we are sure that the resolved seek results in a content period and never an ad period. #minor-release Issue: #122 PiperOrigin-RevId: 471827072 (cherry picked from commit 73f8668)
Media3 Version
1.0.0-beta01
Devices that reproduce the issue
Pixel 5 running Android 12
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Yes
Reproduction steps
It's reproducible in the session demo with some modifications. To expose this issue, you need to configure ads support/IMA like it's done in the main sample.
Steps:
Expected result
Seek should finish without crash, all mid-rolls should be played
Actual result
App crashes
Media
VMAP pre-roll single ad, mid-roll optimized pod with 3 ads, post-roll single ad:
Stack trace
Bug Report
adb bugreport
to [email protected] after filing this issue.The text was updated successfully, but these errors were encountered: