-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PlayerControlView incorrectly mirrors next/prev and ffwd/rewind icons in RTL #227
Comments
Based on the XML snippet it looks like you might be using
I agree the icons being reversed in RTL is a bug - I will keep this open to track resolving that. Reference for time-related playback icons not being mirrored in RTL: https://m2.material.io/design/usability/bidirectionality.html#mirroring-elements |
thank you, indeed im using it without PlayerView. but im not able to achieve the required behaviour here. I just need PlayerControlView (audio only) and I need it to show/hide at the bottom of the activity. Is there any issue continuing with PlayerControlView without PlayerView. It seems it works fine for now. Layout might not be optimum using a fixed hight but at least works |
You're welcome to use it like this, but by "not supported" I mean that we won't be able to help with issues you encounter due to this choice. |
I'm not able to reproduce your RTL problem in the demo app. When I change the language to an RTL one I see the controls look the same as when I view it in english. Please can you see if you're able to reproduce it there? If not then I suspect it's another side-effect of using |
What happens if you actually run the demo app on a real device in an RTL language? That's what I tried (Pixel 5 running Android 13) and didn't observe a problem. I tried the following ways to introduce an RTL layout:
All of these affected other UI elements like back arrows as expected - but none had the effect on the playback controls shown in your screenshots. |
What do you observe if you change the system-wide language using the settings UI rather than overriding it in code? |
you can see the top status bar is inverted because the it is system wide language (ar). i have removed that code. now i remember samsung android is doing a lot of things related to RTL language to make most of the app works out of the box. i noticed this behavior when testing on Huawei old phone at one point of time. not sure if this is what you are facing here. |
Do you have other devices you could try on? Or on an emulator in Android Studio? I'd like to understand if the difference between what we're seeing is due to the specific Samsung device you're using. |
I'm afraid without being able to reproduce the problem it's hard to investigate further. Can you try with the demo app in the emulator? That might be as similar as we can get to each other. I used a Pixel 5 API 33 emulator with the demo app built from 1.0.0-beta03 (no code changes) and I enabled 'force RTL' in developer options. I see this: |
ok i just recognised that i added additional RTL support in the manifest
yes without this line RTL is not activated fully and you will not see this issue. please try it |
Thanks - I can now reproduce the problem. |
Issue: androidx/media#227 #minor-release PiperOrigin-RevId: 497159283
We might as well keep this enabled by default, rather than having to manually toggle it on to investigate RTL issues like Issue: androidx/media#227. PiperOrigin-RevId: 497159744
Issue: #227 #minor-release PiperOrigin-RevId: 497159283
We might as well keep this enabled by default, rather than having to manually toggle it on to investigate RTL issues like Issue: #227. PiperOrigin-RevId: 497159744
Issue: androidx/media#227 #minor-release PiperOrigin-RevId: 497159283 (cherry picked from commit 8313af1)
We might as well keep this enabled by default, rather than having to manually toggle it on to investigate RTL issues like Issue: androidx/media#227. PiperOrigin-RevId: 497159744 (cherry picked from commit 010c6b9)
Media3 Version
1.0.0-beta03
Devices that reproduce the issue
Samsung S22+ Android 13
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Not tested
Reproduction steps
My App is RTL and no control playback is shown (snapshot below) when layout_height=wrap_content
if I increase the height manually it will render normally
another issue is the next back icones are reversed
Expected result
icons should be reversed and all playback controls should be shown
Actual result
as attached
Media
Bug Report
adb bugreport
to [email protected] after filing this issue.The text was updated successfully, but these errors were encountered: